perf triage report for 2023-08-14.

Author: pnkfelix

triage/2023-08-14.md

@@ -1,8 +1,9 @@
 # 2023-08-14 Triage Log
 
-TODO: Summary
+A light week. Main thing to report is we got some improvements from telling LLVM
+that the negation in `<*const T>::sub` cannot overflow.
 
-Triage done by **@???**.
+Triage done by **@pnkfelix**.
 Revision range: [443c3161..e8459109](https://perf.rust-lang.org/?start=443c3161dd04f4c1b656a626f9079921bee9c326&end=e8459109bbb440764c1c877032189a27b9e76c4e&absolute=false&stat=instructions%3Au)
 
 **Summary**:
@@ -16,7 +17,7 @@ Revision range: [443c3161..e8459109](https://perf.rust-lang.org/?start=443c3161d
 | All ❌✅ (primary)                 | -0.7% | [-1.6%, -0.4%] | 11    |
 
 
-0 Regressions, 1 Improvements, 4 Mixed; ??? of them in rollups
+0 Regressions, 1 Improvements, 4 Mixed; 1 of them in rollups
 49 artifact comparisons made in total
 
 #### Regressions
@@ -48,6 +49,8 @@ Rollup of 7 pull requests [#114604](https://github.com/rust-lang/rust/pull/11460
 | Improvements ✅ <br /> (secondary) | -1.0% | [-1.5%, -0.5%] | 2     |
 | All ❌✅ (primary)                 | 0.5%  | [-0.9%, 2.0%]  | 5     |
 
+* already marked as triaged due to follow-up PR #114648
+
 
 Only resolve target type in `try_coerce` in new solver [#114648](https://github.com/rust-lang/rust/pull/114648) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=832db2fcee27ee1079608ac78f82b7c14394e89b&end=fd1698860086db56e047f38d74337cf24dac5f24&stat=instructions:u)
 
@@ -59,6 +62,11 @@ Only resolve target type in `try_coerce` in new solver [#114648](https://github.
 | Improvements ✅ <br /> (secondary) | -     | -              | 0     |
 | All ❌✅ (primary)                 | -0.8% | [-1.8%, 1.0%]  | 3     |
 
+* This was specifically added to undo regressions flagged in PR #114604
+* it did indeed undo the big changes: e.g. cranelift-codegen-0.82.1 had regressed by {2%, 1.7%}, and this improved it back by {-1.84%, -1.59%}
+* likewise cargo-0.60.0 had improved by -0.93%, and this regressed it back by 0.99%. (I.e. we returned to prior status quo.)
+* some other effects were not addressed by this PR, but they are all minor.
+* marking as triaged.
 
 Only check outlives goals on impl compared to trait [#109356](https://github.com/rust-lang/rust/pull/109356) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b08dd92552d663e3c877c8e5ce859e212205a09f&end=f1b854818db00bec14accbc9d1c72e6ebefe64db&stat=instructions:u)
 
@@ -70,6 +78,8 @@ Only check outlives goals on impl compared to trait [#109356](https://github.com
 | Improvements ✅ <br /> (secondary) | -     | -              | 0     |
 | All ❌✅ (primary)                 | -0.9% | [-1.6%, -0.6%] | 6     |
 
+* regression is solely to the opt and debug profiles externs secondary benchmark, by a small amount.
+* marked as triaged
 
 Respect `#[expect]` the same way `#[allow]` is with the `dead_code` lint [#114710](https://github.com/rust-lang/rust/pull/114710) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f1b854818db00bec14accbc9d1c72e6ebefe64db&end=1e836d12d39ea09b1d86ebda70cb11b41564cead&stat=instructions:u)
 
@@ -81,6 +91,8 @@ Respect `#[expect]` the same way `#[allow]` is with the `dead_code` lint [#11471
 | Improvements ✅ <br /> (secondary) | -0.6% | [-0.8%, -0.5%] | 3     |
 | All ❌✅ (primary)                 | 0.5%  | [0.3%, 0.7%]   | 2     |
 
+* seems like noise
+* marked as triaged
 
 #### Untriaged Pull Requests
 
@@ -114,8 +126,3 @@ Respect `#[expect]` the same way `#[allow]` is with the `dead_code` lint [#11471
 - [#111524 `ascii::Char`-ify the escaping code in `core`](https://github.com/rust-lang/rust/pull/111524)
 - [#111425 Populate effective visibilities in `rustc_privacy` (take 2)](https://github.com/rust-lang/rust/pull/111425)
 - [#111364 Remove the ThinLTO CU hack](https://github.com/rust-lang/rust/pull/111364)
-
-#### Nags requiring follow up
-
-TODO: Nags
-