Fix clippy

Author: Kobzol

collector/src/bin/collector.rs

@@ -1193,7 +1193,7 @@ fn binary_stats_local(args: BinaryStatsLocal, symbols: bool) -> anyhow::Result<(
         .artifact2
         .as_ref()
         .map(|path| {
-            ArtifactStats::from_path(&path)
+            ArtifactStats::from_path(path)
                 .with_context(|| format!("Cannot load artifact from {}", path.display()))
         })
         .transpose()?;

collector/src/compile/execute/profiler.rs

@@ -117,7 +117,7 @@ impl<'a> Processor for ProfileProcessor<'a> {
                         fs::remove_dir_all(&zsp_dir)?;
                     }
 
-                    utils::fs::rename(&tmp_zsp_dir, &zsp_dir)?;
+                    utils::fs::rename(tmp_zsp_dir, &zsp_dir)?;
 
                     // Rename the data files. There should be exactly three.
                     let mut num_files = 0;
@@ -305,8 +305,8 @@ impl<'a> Processor for ProfileProcessor<'a> {
                         message_type: &'a str,
                     }
 
-                    let mut final_file = io::BufWriter::new(std::fs::File::create(&eprintln_file)?);
-                    for line in io::BufReader::new(std::fs::File::open(&tmp_eprintln_file)?).lines()
+                    let mut final_file = io::BufWriter::new(std::fs::File::create(eprintln_file)?);
+                    for line in io::BufReader::new(std::fs::File::open(tmp_eprintln_file)?).lines()
                     {
                         let line = line?;
 
@@ -327,11 +327,11 @@ impl<'a> Processor for ProfileProcessor<'a> {
                 // dir, giving it a new name in the process.
                 Profiler::MonoItems => {
                     let tmp_file = filepath(data.cwd, "mono-items");
-                    let out_dir = self.output_dir.join(&out_file("mono-items"));
+                    let out_dir = self.output_dir.join(out_file("mono-items"));
                     let _ = fs::create_dir_all(&out_dir);
                     let result_file = filepath(&out_dir, "raw");
 
-                    fs::copy(&tmp_file, &result_file)?;
+                    fs::copy(&tmp_file, result_file)?;
 
                     let mut by_cgu: HashMap<&str, Vec<(&str, &str)>> = HashMap::new();
                     let mono_items = std::fs::read_to_string(&tmp_file)?;

site/src/comparison.rs

@@ -975,7 +975,7 @@ impl ArtifactDescription {
         let bootstrap_total = bootstrap
             .values()
             .filter_map(|v| {
-                v.get(0)
+                v.first()
                     .copied()
                     .unwrap_or_default()
                     .map(|v| v.as_nanos() as u64)

site/src/request_handlers/self_profile.rs

@@ -534,7 +534,7 @@ pub async fn handle_self_profile(
 
     let mut self_profile = get_or_download_self_profile(
         ctxt,
-        commits.get(0).unwrap().clone(),
+        commits.first().unwrap().clone(),
         bench_name,
         profile,
         scenario,

site/src/server.rs

@@ -573,7 +573,7 @@ where
                 .into_owned()
                 .collect()
         })
-        .unwrap_or_else(HashMap::new);
+        .unwrap_or_default();
 
     match serde_json::from_str(&serde_json::to_string(&params).unwrap()) {
         Ok(d) => Ok(d),