display % total time

Author: Mark-Simulacrum

site/src/api.rs

@@ -263,6 +263,7 @@ pub mod self_profile {
     pub struct QueryData {
         pub label: String,
         pub self_time: Duration,
+        pub percent_total_time: f32,
         pub number_of_cache_misses: usize,
         pub number_of_cache_hits: usize,
         pub invocation_count: usize,

site/src/server.rs

@@ -633,45 +633,51 @@ fn get_self_profile_data(
         .as_ref()
         .ok_or(format!("No self profile results for this commit"))?
         .clone();
+    let totals = self_profile::QueryData {
+        label: String::from("Totals"),
+        self_time: profile.query_data.iter().map(|qd| qd.self_time).sum(),
+        // TODO: check against wall-time from perf stats
+        percent_total_time: 100.0,
+        number_of_cache_misses: profile
+            .query_data
+            .iter()
+            .map(|qd| qd.number_of_cache_misses)
+            .sum(),
+        number_of_cache_hits: profile
+            .query_data
+            .iter()
+            .map(|qd| qd.number_of_cache_hits)
+            .sum(),
+        invocation_count: profile
+            .query_data
+            .iter()
+            .map(|qd| qd.invocation_count)
+            .sum(),
+        blocked_time: profile.query_data.iter().map(|qd| qd.blocked_time).sum(),
+        incremental_load_time: profile
+            .query_data
+            .iter()
+            .map(|qd| qd.incremental_load_time)
+            .sum(),
+    };
     let mut profile = self_profile::SelfProfile {
-        totals: self_profile::QueryData {
-            label: String::from("Totals"),
-            self_time: profile.query_data.iter().map(|qd| qd.self_time).sum(),
-            number_of_cache_misses: profile
-                .query_data
-                .iter()
-                .map(|qd| qd.number_of_cache_misses)
-                .sum(),
-            number_of_cache_hits: profile
-                .query_data
-                .iter()
-                .map(|qd| qd.number_of_cache_hits)
-                .sum(),
-            invocation_count: profile
-                .query_data
-                .iter()
-                .map(|qd| qd.invocation_count)
-                .sum(),
-            blocked_time: profile.query_data.iter().map(|qd| qd.blocked_time).sum(),
-            incremental_load_time: profile
-                .query_data
-                .iter()
-                .map(|qd| qd.incremental_load_time)
-                .sum(),
-        },
         query_data: profile
             .query_data
             .into_iter()
             .map(|qd| self_profile::QueryData {
                 label: qd.label,
                 self_time: qd.self_time,
+                percent_total_time: ((qd.self_time.as_nanos() as f64
+                    / totals.self_time.as_nanos() as f64)
+                    * 100.0) as f32,
                 number_of_cache_misses: qd.number_of_cache_misses,
                 number_of_cache_hits: qd.number_of_cache_hits,
                 invocation_count: qd.invocation_count,
                 blocked_time: qd.blocked_time,
                 incremental_load_time: qd.incremental_load_time,
             })
             .collect(),
+        totals,
     };
 
     if let Some(sort_idx) = sort_idx {
@@ -693,6 +699,11 @@ fn get_self_profile_data(
                     ((qd.number_of_cache_hits as f64 / qd.invocation_count as f64) * 10_000.0)
                         as u64
                 }),
+                10 => profile.query_data.sort_by(|a, b| {
+                    a.percent_total_time
+                        .partial_cmp(&b.percent_total_time)
+                        .unwrap()
+                }),
                 _ => break,
             }
 

site/static/detailed-query.html

@@ -47,6 +47,7 @@ <h3 id="title"></h3>
                 <tr id="table-header">
                     <th data-sort-idx="1" data-default-sort-dir="1">Query/Function</th>
                     <th data-sort-idx="2" data-default-sort-dir="-1">Time</th>
+                    <th data-sort-idx="10" data-default-sort-dir="-1">% Total Time</th>
                     <th class="delta">Δ</th>
                     <th data-sort-idx="5" data-default-sort-dir="-1">Invocations</th>
                     <th class="delta">Δ</th>
@@ -143,7 +144,7 @@ <h3 id="title"></h3>
                 let cur = to_object(element);
                 let prev = null;
                 if (data.base_profile) {
-                    for (let prev_el of data.base_profile[0]) {
+                    for (let prev_el of [data.base_profile[0], ...data.base_profile[1]]) {
                         if (to_object(prev_el).label == cur.label) {
                             prev = to_object(prev_el);
                             break;
@@ -158,12 +159,14 @@ <h3 id="title"></h3>
                         td.classList.add("delta");
                     }
                     row.appendChild(td);
+                    return td;
                 }
                 if (idx == 0) {
                     row.style.fontStyle = "italic";
                 }
                 td(row, cur.label);
                 td(row, to_seconds(cur.self_time).toFixed(3));
+                td(row, cur.percent_total_time.toFixed(2));
                 if (prev) {
                     td(row, fmt_delta(to_seconds(prev.self_time), to_seconds(cur.self_time)), true);
                 } else {
@@ -199,9 +202,11 @@ <h3 id="title"></h3>
 
         function to_object(element) {
             if (!element.length) {
+                console.log("element:", element);
                 element = [
                     element.label,
                     [ element.self_time.secs, element.self_time.nanos ],
+                    element.percent_total_time,
                     element.number_of_cache_misses,
                     element.number_of_cache_hits,
                     element.invocation_count,
@@ -210,13 +215,14 @@ <h3 id="title"></h3>
                 ];
             }
             let [
-                label, self_time, cache_misses,
+                label, self_time, percent_total_time, cache_misses,
                 _cache_hits, invocation_count, _blocked_time,
                 incremental_load_time
             ] = element;
             return {
                 label,
                 self_time,
+                percent_total_time,
                 cache_misses,
                 invocation_count,
                 incremental_load_time,