Display wall-time stat comparison

Author: Mark-Simulacrum

site/src/server.rs

@@ -633,11 +633,20 @@ fn get_self_profile_data(
         .as_ref()
         .ok_or(format!("No self profile results for this commit"))?
         .clone();
+    let total_time = profile.query_data.iter().map(|qd| qd.self_time).sum();
     let totals = self_profile::QueryData {
         label: String::from("Totals"),
-        self_time: profile.query_data.iter().map(|qd| qd.self_time).sum(),
+        self_time: total_time,
         // TODO: check against wall-time from perf stats
-        percent_total_time: 100.0,
+        percent_total_time: run
+            .stats
+            .get(StatId::CpuClock)
+            .map(|w| {
+                // this converts the total_time (a Duration) to the milliseconds in cpu-clock
+                (((total_time.as_nanos() as f64 / 1000000.0) / w) * 100.0) as f32
+            })
+            // sentinel "we couldn't compute this time"
+            .unwrap_or(-100.0),
         number_of_cache_misses: profile
             .query_data
             .iter()

site/static/detailed-query.html

@@ -42,6 +42,8 @@
         <a href="dashboard.html">dashboard</a>, <a href="status.html">status</a>.</div>
     <div id="content">
         <h3 id="title"></h3>
+        <p>Totals row '%total time' is as a comparison to the 'cpu-clock' stat (we do not use
+        wall-time as we want to account for parallelism).</p>
         <table>
             <thead>
                 <tr id="table-header">
@@ -166,7 +168,15 @@ <h3 id="title"></h3>
                 }
                 td(row, cur.label);
                 td(row, to_seconds(cur.self_time).toFixed(3));
-                td(row, cur.percent_total_time.toFixed(2));
+                if (cur.percent_total_time < 0) {
+                    td(row, "-").setAttribute("title", "No wall-time stat collected for this run");
+                } else {
+                    let t = td(row, cur.percent_total_time.toFixed(2) + "%");
+                    if (idx == 0) {
+                        t.innerText += "*";
+                        t.setAttribute("title", "% of wall-time stat");
+                    }
+                }
                 if (prev) {
                     td(row, fmt_delta(to_seconds(prev.self_time), to_seconds(cur.self_time)), true);
                 } else {