Skip to content

Commit dd296e1

Browse files
committed
fleshed out summary and filled in PR 111869 but did not mark it as triaged.
1 parent fb1d341 commit dd296e1

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

triage/2023-05-30.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# 2023-05-30 Triage Log
22

33
A good week overall, with a broad set of improvements to many primary benchmarks.
4+
The main single source of primary regressions is from rollup PR #111869; we are
5+
in the process of narrowing that down to see if there is a root cause.
46

57
Triage done by **@pnkfelix**.
68
Revision range: [cda5becc..1221e43b](https://perf.rust-lang.org/?start=cda5becc27cbc7106646fbc40aacea5e7896d954&end=1221e43bdf413f7c405e9b17ef19d76c88222098&absolute=false&stat=instructions%3Au)
@@ -43,7 +45,8 @@ Rollup of 6 pull requests [#111869](https://github.com/rust-lang/rust/pull/11186
4345
| Improvements ✅ <br /> (secondary) | - | - | 0 |
4446
| All ❌✅ (primary) | 0.4% | [0.2%, 0.6%] | 12 |
4547

46-
* TODO, come back to this later
48+
* The five primary regressions over 0.4% are to diesel full and incr-full scenarios.
49+
* It is not clear what caused these regressions; pnkfelix started requesting individual rust-timer runs, but has not yet identified any root cause.
4750

4851
Support #[global_allocator] without the allocator shim [#86844](https://github.com/rust-lang/rust/pull/86844) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=cade26637fe1c23965ce644299ed5200db7c92dd&end=a2b1646c597329d0a25efa3889b66650f65de1de&stat=instructions:u)
4952

0 commit comments

Comments
 (0)