Skip to content

Commit e0f25f5

Browse files
committed
Fix current unit test
1 parent 341c300 commit e0f25f5

File tree

2 files changed

+18
-17
lines changed

2 files changed

+18
-17
lines changed

database/src/pool.rs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1098,54 +1098,54 @@ mod tests {
10981098

10991099
assert!(status_page_data.in_progress.len() == 1);
11001100
// we should have 2 jobs
1101-
assert!(status_page_data.in_progress[0].1.len() == 2);
1101+
assert!(status_page_data.in_progress[0].request.1.len() == 2);
11021102
// the request should be in progress
11031103
assert!(matches!(
1104-
status_page_data.in_progress[0].0.status(),
1104+
status_page_data.in_progress[0].request.0.status(),
11051105
BenchmarkRequestStatus::InProgress
11061106
));
11071107

11081108
// Test the first job
11091109
assert!(matches!(
1110-
status_page_data.in_progress[0].1[0].target(),
1110+
status_page_data.in_progress[0].request.1[0].target(),
11111111
Target::X86_64UnknownLinuxGnu
11121112
));
11131113
assert!(matches!(
1114-
status_page_data.in_progress[0].1[0].status(),
1114+
status_page_data.in_progress[0].request.1[0].status(),
11151115
BenchmarkJobStatus::Queued
11161116
));
11171117
assert!(matches!(
1118-
status_page_data.in_progress[0].1[0].backend(),
1118+
status_page_data.in_progress[0].request.1[0].backend(),
11191119
CodegenBackend::Llvm
11201120
));
11211121
assert!(matches!(
1122-
status_page_data.in_progress[0].1[0].profile(),
1122+
status_page_data.in_progress[0].request.1[0].profile(),
11231123
Profile::Opt
11241124
));
11251125
assert_eq!(
1126-
status_page_data.in_progress[0].1[0].benchmark_set(),
1126+
status_page_data.in_progress[0].request.1[0].benchmark_set(),
11271127
benchmark_set
11281128
);
11291129

11301130
// test the second job
11311131
assert!(matches!(
1132-
status_page_data.in_progress[0].1[1].target(),
1132+
status_page_data.in_progress[0].request.1[1].target(),
11331133
Target::X86_64UnknownLinuxGnu
11341134
));
11351135
assert!(matches!(
1136-
status_page_data.in_progress[0].1[1].status(),
1136+
status_page_data.in_progress[0].request.1[1].status(),
11371137
BenchmarkJobStatus::Queued
11381138
));
11391139
assert!(matches!(
1140-
status_page_data.in_progress[0].1[1].backend(),
1140+
status_page_data.in_progress[0].request.1[1].backend(),
11411141
CodegenBackend::Llvm
11421142
));
11431143
assert!(matches!(
1144-
status_page_data.in_progress[0].1[1].profile(),
1144+
status_page_data.in_progress[0].request.1[1].profile(),
11451145
Profile::Debug
11461146
));
11471147
assert_eq!(
1148-
status_page_data.in_progress[0].1[1].benchmark_set(),
1148+
status_page_data.in_progress[0].request.1[1].benchmark_set(),
11491149
benchmark_set
11501150
);
11511151

database/src/pool/postgres.rs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2156,17 +2156,18 @@ where
21562156
.map(|it| benchmark_job_str_to_type(it).unwrap())
21572157
.collect();
21582158

2159-
let parent_benchmark_request = row_to_benchmark_request(it, Some(12));
2160-
21612159
// This is ever-so-slightly grim however it allows us to not
21622160
// have to parse the text representation of the jobs. Which
21632161
// saves a reasonable amount of time to justify doing this.
2164-
let parent_active = it.get::<_, bool>("parent_active");
2162+
let parent_active = it.get::<_, Option<bool>>("parent_active");
21652163

21662164
InProgressRequestWithJobs {
21672165
request: (benchmark_request, jobs),
2168-
parent: if parent_active {
2169-
// only parse the jobs if we need to include the parent
2166+
parent: if parent_active.unwrap_or(false) {
2167+
// The rows values will only be non-null if the `parent_active`
2168+
// has been set
2169+
let parent_benchmark_request = row_to_benchmark_request(it, Some(12));
2170+
// Only parse the jobs if we need to include the parent
21702171
let parent_jobs: Vec<BenchmarkJob> = it
21712172
.get::<_, Vec<String>>("parent_jobs")
21722173
.iter()

0 commit comments

Comments
 (0)