Merge pull request #2209 from Kobzol/compare-changes-filter

Add changes filter to compare page

Author: Kobzol

site/frontend/src/pages/compare/compile/common.ts

@@ -27,6 +27,10 @@ export type CompileBenchmarkFilter = {
     binary: boolean;
     library: boolean;
   };
+  changes: {
+    regressions: boolean;
+    improvements: boolean;
+  };
   selfCompareBackend: boolean;
 } & BenchmarkFilter;
 
@@ -58,6 +62,10 @@ export const defaultCompileFilter: CompileBenchmarkFilter = {
     binary: true,
     library: true,
   },
+  changes: {
+    regressions: true,
+    improvements: true,
+  },
   selfCompareBackend: false,
 };
 
@@ -154,6 +162,16 @@ export function computeCompileComparisonsWithNonRelevant(
     return true;
   }
 
+  function changeFilter(
+    comparison: TestCaseComparison<CompileTestCase>
+  ): boolean {
+    const isImprovement = comparison.percent <= 0.0;
+    if (isImprovement && !filter.changes.improvements) return false;
+    if (!isImprovement && !filter.changes.regressions) return false;
+
+    return true;
+  }
+
   function categoryFilter(category: Category) {
     if (category === "primary" && !filter.category.primary) return false;
     if (category === "secondary" && !filter.category.secondary) return false;
@@ -167,6 +185,7 @@ export function computeCompileComparisonsWithNonRelevant(
       backendFilter(comparison.testCase.backend) &&
       categoryFilter(comparison.testCase.category) &&
       artifactFilter(benchmarkMap[comparison.testCase.benchmark] ?? null) &&
+      changeFilter(comparison) &&
       benchmarkNameMatchesFilter(comparison.testCase.benchmark, filter.name)
     );
   }

site/frontend/src/pages/compare/compile/compile-page.vue

@@ -102,6 +102,18 @@ function loadFilterFromUrl(
         defaultFilter.artifact.library
       ),
     },
+    changes: {
+      regressions: getBoolOrDefault(
+        urlParams,
+        "regressions",
+        defaultFilter.changes.regressions
+      ),
+      improvements: getBoolOrDefault(
+        urlParams,
+        "improvements",
+        defaultCompileFilter.changes.improvements
+      ),
+    },
     selfCompareBackend: getBoolOrDefault(
       urlParams,
       "selfCompareBackend",
@@ -178,6 +190,16 @@ function storeFilterToUrl(
     filter.artifact.library,
     defaultFilter.artifact.library
   );
+  storeOrReset(
+    "regressions",
+    filter.changes.regressions,
+    defaultFilter.changes.regressions
+  );
+  storeOrReset(
+    "improvements",
+    filter.changes.improvements,
+    defaultFilter.changes.improvements
+  );
   storeOrReset(
     "selfCompareBackend",
     filter.selfCompareBackend,

site/frontend/src/pages/compare/compile/filters.vue

@@ -259,6 +259,33 @@ const opened = createPersistedRef(PREF_FILTERS_OPENED);
               </li>
             </ul>
           </div>
+          <div class="section section-list-wrapper">
+            <div class="section-heading">
+              <div style="width: 160px">
+                <span>Changes</span>
+                <Tooltip>
+                  Select only improvements, only regressions, or both.
+                </Tooltip>
+              </div>
+            </div>
+            <ul class="states-list">
+              <li>
+                <label>
+                  <input type="checkbox" v-model="filter.changes.regressions" />
+                  <span class="label">regressions</span>
+                </label>
+              </li>
+              <li>
+                <label>
+                  <input
+                    type="checkbox"
+                    v-model="filter.changes.improvements"
+                  />
+                  <span class="label">improvements</span>
+                </label>
+              </li>
+            </ul>
+          </div>
           <div class="section">
             <div class="section-heading">
               <span>Show non-relevant results</span>