Skip to content

Commit eee4f66

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent cbc8105 commit eee4f66

File tree

1 file changed

+207
-0
lines changed

1 file changed

+207
-0
lines changed

‎triage/2024-04-09.md

Lines changed: 207 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,207 @@
1+
# 2024-04-09 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [3d5528c287860b918e178a34f04ff903325571b3..86b603cd792b3f6172ba4f676d7b586c1af7630a](https://perf.rust-lang.org/?start=3d5528c287860b918e178a34f04ff903325571b3&end=86b603cd792b3f6172ba4f676d7b586c1af7630a&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 2.0% | [0.4%, 5.0%] | 83 |
13+
| Regressions ❌ <br /> (secondary) | 2.1% | [0.5%, 4.8%] | 79 |
14+
| Improvements ✅ <br /> (primary) | -1.5% | [-2.9%, -0.3%] | 121 |
15+
| Improvements ✅ <br /> (secondary) | -1.4% | [-3.5%, -0.3%] | 67 |
16+
| All ❌✅ (primary) | -0.1% | [-2.9%, 5.0%] | 204 |
17+
18+
19+
3 Regressions, 3 Improvements, 7 Mixed; ??? of them in rollups
20+
78 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
instantiate higher ranked goals outside of candidate selection [#119820](https://github.com/rust-lang/rust/pull/119820) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0accf4ec4c07d23aa86f6a97aeb8797941abc30e&end=43f4f2a3b1a3d3fb3dbbbe4fde33fb97c780ee98&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.6% | [0.3%, 0.8%] | 8 |
29+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.6% | [0.3%, 0.8%] | 8 |
33+
34+
35+
Pass list of defineable opaque types into canonical queries [#122077](https://github.com/rust-lang/rust/pull/122077) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ab5bda1aa70f707014e2e691e43bc37a8819252a&end=b234e449443a49ab19ef6b712bf56cc65927d98f&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:-----:|:--------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 1.9% | [0.2%, 5.4%] | 101 |
40+
| Regressions ❌ <br /> (secondary) | 2.3% | [0.3%, 4.7%] | 77 |
41+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.6%, -0.6%] | 1 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 1.8% | [-0.6%, 5.4%] | 102 |
44+
45+
46+
Replace some `CrateStore` trait methods with hooks. [#123099](https://github.com/rust-lang/rust/pull/123099) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=59c808fcd9eeb3c5528209d1cef3aaa5521edbd6&end=bd12986fd6659a3091cff7694b8225374f4a26fe&stat=instructions:u)
47+
48+
| (instructions:u) | mean | range | count |
49+
|:----------------------------------:|:----:|:------------:|:-----:|
50+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 14 |
51+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.4%] | 2 |
52+
| Improvements ✅ <br /> (primary) | - | - | 0 |
53+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
54+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.4%] | 14 |
55+
56+
57+
#### Improvements
58+
59+
hir: Drop owner's own item-local id (zero) from parenting tables [#123415](https://github.com/rust-lang/rust/pull/123415) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=703dc9ce64d9b31a239a7280d9b5f9ddd85ffed6&end=98efd808e1b77cd70a097620aad6250727167a28&stat=instructions:u)
60+
61+
| (instructions:u) | mean | range | count |
62+
|:----------------------------------:|:-----:|:--------------:|:-----:|
63+
| Regressions ❌ <br /> (primary) | - | - | 0 |
64+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
65+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 3 |
66+
| Improvements ✅ <br /> (secondary) | -0.4% | [-1.3%, -0.3%] | 13 |
67+
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.2%] | 3 |
68+
69+
70+
[perf] cache type info for ParamEnv [#123058](https://github.com/rust-lang/rust/pull/123058) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6f837503aa120ca69c2985b6c9a474c00674cef1&end=087ae978a13013800c8a484cf17c8951ab0b6b0c&stat=instructions:u)
71+
72+
| (instructions:u) | mean | range | count |
73+
|:----------------------------------:|:-----:|:--------------:|:-----:|
74+
| Regressions ❌ <br /> (primary) | - | - | 0 |
75+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
76+
| Improvements ✅ <br /> (primary) | -0.9% | [-4.9%, -0.2%] | 47 |
77+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
78+
| All ❌✅ (primary) | -0.9% | [-4.9%, -0.2%] | 47 |
79+
80+
81+
Remove debuginfo from rustc-demangle too [#123608](https://github.com/rust-lang/rust/pull/123608) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0e5f5207881066973486e6a480fa46cfa22947e9&end=75fd074338801fba74a8cf7f8c48c5c5be362d08&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:-----:|:--------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | - | - | 0 |
86+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.4%, 0.9%] | 4 |
87+
| Improvements ✅ <br /> (primary) | -1.6% | [-2.7%, -0.3%] | 7 |
88+
| Improvements ✅ <br /> (secondary) | -1.3% | [-2.4%, -0.3%] | 24 |
89+
| All ❌✅ (primary) | -1.6% | [-2.7%, -0.3%] | 7 |
90+
91+
92+
#### Mixed
93+
94+
Add `Ord::cmp` for primitives as a `BinOp` in MIR [#118310](https://github.com/rust-lang/rust/pull/118310) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=029cb1b13b6388b95e64e8996ec8b41a9f3cf16e&end=a77322c16f188402fa22a5e87100acce42433cbc&stat=instructions:u)
95+
96+
| (instructions:u) | mean | range | count |
97+
|:----------------------------------:|:-----:|:--------------:|:-----:|
98+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.7%] | 3 |
99+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.4%] | 2 |
100+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.6%, -0.6%] | 1 |
101+
| Improvements ✅ <br /> (secondary) | -3.1% | [-3.1%, -3.1%] | 1 |
102+
| All ❌✅ (primary) | 0.2% | [-0.6%, 0.7%] | 4 |
103+
104+
105+
Encode dep graph edges directly from the previous graph when promoting [#122070](https://github.com/rust-lang/rust/pull/122070) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d009f60b55fe4527e7ddf122bc4520f351d7b9d4&end=4563f70c3b599411836e285591479f4a3d364708&stat=instructions:u)
106+
107+
| (instructions:u) | mean | range | count |
108+
|:----------------------------------:|:-----:|:--------------:|:-----:|
109+
| Regressions ❌ <br /> (primary) | - | - | 0 |
110+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.4%, 0.4%] | 1 |
111+
| Improvements ✅ <br /> (primary) | -1.6% | [-3.1%, -0.2%] | 113 |
112+
| Improvements ✅ <br /> (secondary) | -1.5% | [-3.6%, -0.3%] | 37 |
113+
| All ❌✅ (primary) | -1.6% | [-3.1%, -0.2%] | 113 |
114+
115+
116+
Implement T-types suggested logic for perfect non-local impl detection [#122747](https://github.com/rust-lang/rust/pull/122747) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ea40fa210b87a322d2259852c149ffa212a3a0da&end=9d79cd5f79e75bd0d2083260271307ce9acd9081&stat=instructions:u)
117+
118+
| (instructions:u) | mean | range | count |
119+
|:----------------------------------:|:-----:|:--------------:|:-----:|
120+
| Regressions ❌ <br /> (primary) | 2.3% | [0.6%, 4.4%] | 12 |
121+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
122+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 9 |
123+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
124+
| All ❌✅ (primary) | 1.2% | [-0.4%, 4.4%] | 21 |
125+
126+
127+
Remove sharding for VecCache [#123556](https://github.com/rust-lang/rust/pull/123556) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=087ae978a13013800c8a484cf17c8951ab0b6b0c&end=af2525317be950fdae635bcbb46b3e755d14ab49&stat=instructions:u)
128+
129+
| (instructions:u) | mean | range | count |
130+
|:----------------------------------:|:-----:|:--------------:|:-----:|
131+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.4%] | 1 |
132+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.2%, 1.0%] | 5 |
133+
| Improvements ✅ <br /> (primary) | - | - | 0 |
134+
| Improvements ✅ <br /> (secondary) | -0.9% | [-1.1%, -0.7%] | 4 |
135+
| All ❌✅ (primary) | 0.4% | [0.4%, 0.4%] | 1 |
136+
137+
138+
Use unchecked_sub in str indexing [#123561](https://github.com/rust-lang/rust/pull/123561) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fc1a4c5cc9308c4b5980c64a73fd344a59c10601&end=4e431fad67b46c480f1833119cd368fa33df95f7&stat=instructions:u)
139+
140+
| (instructions:u) | mean | range | count |
141+
|:----------------------------------:|:-----:|:--------------:|:-----:|
142+
| Regressions ❌ <br /> (primary) | 0.9% | [0.9%, 0.9%] | 1 |
143+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
144+
| Improvements ✅ <br /> (primary) | - | - | 0 |
145+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.9%, -0.4%] | 7 |
146+
| All ❌✅ (primary) | 0.9% | [0.9%, 0.9%] | 1 |
147+
148+
149+
Rollup of 9 pull requests [#123645](https://github.com/rust-lang/rust/pull/123645) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=211518e5fb1336de6a4aab45dc1c05f5d83ce856&end=ab5bda1aa70f707014e2e691e43bc37a8819252a&stat=instructions:u)
150+
151+
| (instructions:u) | mean | range | count |
152+
|:----------------------------------:|:-----:|:--------------:|:-----:|
153+
| Regressions ❌ <br /> (primary) | 0.6% | [0.6%, 0.6%] | 1 |
154+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
155+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.3%] | 2 |
156+
| Improvements ✅ <br /> (secondary) | -1.8% | [-1.8%, -1.8%] | 1 |
157+
| All ❌✅ (primary) | -0.0% | [-0.4%, 0.6%] | 3 |
158+
159+
160+
Only collect mono items from reachable blocks [#123272](https://github.com/rust-lang/rust/pull/123272) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=86b603cd792b3f6172ba4f676d7b586c1af7630a&end=bb78dba64ca4158ef2f3488d0d41a82c75a504f2&stat=instructions:u)
161+
162+
| (instructions:u) | mean | range | count |
163+
|:----------------------------------:|:-----:|:--------------:|:-----:|
164+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 1.5%] | 8 |
165+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
166+
| Improvements ✅ <br /> (primary) | -0.8% | [-1.5%, -0.3%] | 6 |
167+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
168+
| All ❌✅ (primary) | -0.1% | [-1.5%, 1.5%] | 14 |
169+
170+
171+
#### Untriaged Pull Requests
172+
173+
- [#123645 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/123645)
174+
- [#123561 Use unchecked_sub in str indexing](https://github.com/rust-lang/rust/pull/123561)
175+
- [#123272 Only collect mono items from reachable blocks](https://github.com/rust-lang/rust/pull/123272)
176+
- [#123147 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/123147)
177+
- [#122976 Remove len argument from RawVec::reserve_for_push](https://github.com/rust-lang/rust/pull/122976)
178+
- [#122900 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/122900)
179+
- [#122671 Codegen const panic messages as function calls](https://github.com/rust-lang/rust/pull/122671)
180+
- [#122396 Less generic code for Vec allocations](https://github.com/rust-lang/rust/pull/122396)
181+
- [#121955 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/121955)
182+
- [#121804 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/121804)
183+
- [#121752 Detect unused struct impls pub trait](https://github.com/rust-lang/rust/pull/121752)
184+
- [#121462 Combine `Sub` and `Equate`](https://github.com/rust-lang/rust/pull/121462)
185+
- [#121345 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/121345)
186+
- [#120985 Update host LLVM on x64 Linux to LLVM 18](https://github.com/rust-lang/rust/pull/120985)
187+
- [#120863 Use intrinsics::debug_assertions in debug_assert_nounwind](https://github.com/rust-lang/rust/pull/120863)
188+
- [#120862 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/120862)
189+
- [#120809 Use `transmute_unchecked` in `NonZero::new`.](https://github.com/rust-lang/rust/pull/120809)
190+
- [#120588 wasm: Store rlib metadata in wasm object files](https://github.com/rust-lang/rust/pull/120588)
191+
- [#120504 Vec::try_with_capacity](https://github.com/rust-lang/rust/pull/120504)
192+
- [#120401 Rollup of 12 pull requests](https://github.com/rust-lang/rust/pull/120401)
193+
- [#120335 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/120335)
194+
- [#119662 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/119662)
195+
- [#119204 macro_rules: Less hacky heuristic for using `tt` metavariable spans](https://github.com/rust-lang/rust/pull/119204)
196+
- [#119002 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/119002)
197+
- [#118661 Restore `const PartialEq`](https://github.com/rust-lang/rust/pull/118661)
198+
- [#118473 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/118473)
199+
- [#118420 Introduce support for `async gen` blocks](https://github.com/rust-lang/rust/pull/118420)
200+
- [#118405 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/118405)
201+
- [#118319 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/118319)
202+
- [#118310 Add `Ord::cmp` for primitives as a `BinOp` in MIR](https://github.com/rust-lang/rust/pull/118310)
203+
204+
#### Nags requiring follow up
205+
206+
TODO: Nags
207+

0 commit comments

Comments
 (0)