Skip to content

Commit fa841a1

Browse files
authored
Merge pull request #1616 from nnethercote/rm-keccak
Remove `keccak`
2 parents 3fa012f + f76b0dc commit fa841a1

File tree

7 files changed

+3
-356
lines changed

7 files changed

+3
-356
lines changed

collector/compile-benchmarks/README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ They mostly consist of real-world crates.
2323
- **clap-3.1.6**: A command line argument parser library. A crate used by many
2424
Rust programs.
2525
- **cranelift-codegen-0.82.1**: The largest crate from a code generator. Used by
26-
wasmtime. Stresses obligation processing, but less than `keccak`.
26+
wasmtime. Stresses obligation processing.
2727
- **diesel-1.4.8**: A type safe SQL query builder. Utilizes the type system to
2828
ensure a lot of invariants. Stresses anything related to resolving
2929
trait bounds, by having a lot of trait impls for a large number of different
@@ -91,8 +91,6 @@ compiler in interesting ways.
9191
- **issue-88862**: A MCVE of a program that had a
9292
[severe performance regression](https://github.com/rust-lang/rust/issues/88862)
9393
when trying to normalize large opaque types with late-bound regions.
94-
- **keccak**: A cryptography algorithm. Contains a huge function with a very
95-
high number of locals and basic blocks, which stresses obligation processing.
9694
- **many-assoc-items**: Contains a struct with many associated items, which
9795
caused [quadratic behavior](https://github.com/rust-lang/rust/issues/68957)
9896
in the past.
@@ -151,8 +149,8 @@ Rust code being written today.
151149
This is why there is no futures crate among the primary benchmarks.
152150
- **html5ever**: See above. This is an older version (v0.5.4) of the crate.
153151
- **inflate**: An old implementation of the DEFLATE algorithm. Contains
154-
a very large function containing many locals and basic blocks, similar to
155-
`keccak` but less extreme.
152+
a very large function containing many locals and basic blocks, which stresses
153+
obligation processing.
156154
- **regex**: See above. This is an older version of the crate.
157155
- **piston-image**: See above. This is an older version of the `image` crate.
158156
- **style-servo**: An old version of Servo's `style` crate. A large crate, and

collector/compile-benchmarks/keccak/Cargo.lock

Lines changed: 0 additions & 6 deletions
This file was deleted.

collector/compile-benchmarks/keccak/Cargo.toml

Lines changed: 0 additions & 18 deletions
This file was deleted.

collector/compile-benchmarks/keccak/LICENSE

Lines changed: 0 additions & 121 deletions
This file was deleted.

collector/compile-benchmarks/keccak/benches/mod.rs

Lines changed: 0 additions & 9 deletions
This file was deleted.

collector/compile-benchmarks/keccak/perf-config.json

Lines changed: 0 additions & 3 deletions
This file was deleted.

collector/compile-benchmarks/keccak/src/lib.rs

Lines changed: 0 additions & 194 deletions
This file was deleted.

0 commit comments

Comments
 (0)