Merge pull request #2144 from Kobzol/test-workspace

Add a test for existence of `[workspace]` in compile benchmarks

Author: Kobzol

collector/compile-benchmarks/cranelift-codegen-0.119.0/Cargo.toml

@@ -250,3 +250,5 @@ check-cfg = [
     "cfg(pulley_tail_calls)",
     "cfg(pulley_assume_llvm_makes_tail_calls)",
 ]
+
+[workspace]

collector/compile-benchmarks/diesel-2.2.10/Cargo.toml

@@ -272,3 +272,5 @@ version = "1.0.3"
 
 [dev-dependencies.tempfile]
 version = "3.10.1"
+
+[workspace]

collector/compile-benchmarks/image-0.25.6/Cargo.toml

@@ -233,3 +233,5 @@ serde = ["dep:serde"]
 tga = []
 tiff = ["dep:tiff"]
 webp = ["dep:image-webp"]
+
+[workspace]

collector/src/compile/benchmark/mod.rs

@@ -620,13 +620,22 @@ mod tests {
     #[test]
     fn check_compile_benchmarks() {
         // Check that we can deserialize all perf-config.json files in the compile benchmark
-        // directory.
+        // directory and that they have [workspace] in their Cargo.toml.
         let root = env!("CARGO_MANIFEST_DIR");
-        let benchmarks = get_compile_benchmarks(
-            &Path::new(root).join("compile-benchmarks"),
-            CompileBenchmarkFilter::All,
-        )
-        .unwrap();
+        let benchmark_dir = Path::new(root).join("compile-benchmarks");
+        let benchmarks =
+            get_compile_benchmarks(&benchmark_dir, CompileBenchmarkFilter::All).unwrap();
         assert!(!benchmarks.is_empty());
+
+        for benchmark in benchmarks {
+            let dir = benchmark_dir.join(&benchmark.name.0);
+            let cargo_toml = std::fs::read_to_string(&dir.join("Cargo.toml"))
+                .expect(&format!("Cannot read Cargo.toml of {}", benchmark.name));
+            assert!(
+                cargo_toml.contains("[workspace]"),
+                "{} does not contain [workspace] in its Cargo.toml",
+                benchmark.name
+            );
+        }
     }
 }