Skip to content

Add perf triage for 2025-02-04 #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Add perf triage for 2025-02-04 #2036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
166 changes: 166 additions & 0 deletions triage/2025-02-04.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,166 @@
# 2025-02-04 Triage Log

A very quiet week with performance of primary benchmarks showing no change over all.

Triage done by **@rylev**.
Revision range: [f7538506..01e4f19c](https://perf.rust-lang.org/?start=f753850659bdf5788332525f3fe395685929c682&end=01e4f19cc8027925ffe0885a86388b700e46bfab&absolute=false&stat=instructions%3Au)

**Summary**:

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:---------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.6%] | 32 |
| Regressions ❌ <br /> (secondary) | 0.5% | [0.1%, 1.1%] | 65 |
| Improvements ✅ <br /> (primary) | -0.5% | [-1.0%, -0.2%] | 17 |
| Improvements ✅ <br /> (secondary) | -3.1% | [-10.3%, -0.2%] | 20 |
| All ❌✅ (primary) | 0.0% | [-1.0%, 0.6%] | 49 |


5 Regressions, 2 Improvements, 5 Mixed; 6 of them in rollups
49 artifact comparisons made in total

#### Regressions

Rollup of 10 pull requests [#136135](https://github.com/rust-lang/rust/pull/136135) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0cffe5cb95e36d45a3e61f7b1f5a9b21eddd77b4&end=ebcf860e7345e3387b4c6961338c77424b43cbd5&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:----:|:------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.3%] | 2 |
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.3%] | 9 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.3% | [0.2%, 0.3%] | 2 |


Rollup of 9 pull requests [#136227](https://github.com/rust-lang/rust/pull/136227) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=61cc3e51f8bf5c12595a4d61a5ee9de812974b43&end=a1d7676d6a8c6ff13f9165e98cc25eeec66cb592&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:----:|:------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 6 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.2% | [0.2%, 0.2%] | 1 |
- Addressed by https://github.com/rust-lang/rust/pull/136253


Merge `PatKind::Path` into `PatKind::Expr` [#134248](https://github.com/rust-lang/rust/pull/134248) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0cc4f4f7b81f88df6bdd54b41d4a0b1703fd014d&end=ae5de6c759cd337ecdb2de4e94f47eaafb5d4606&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:----:|:------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 8 |
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.5%] | 9 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.3% | [0.2%, 0.4%] | 8 |
- https://github.com/rust-lang/rust/pull/134248#issuecomment-2610453075


Insert null checks for pointer dereferences when debug assertions are enabled [#134424](https://github.com/rust-lang/rust/pull/134424) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7f36543a48e52912ac6664a70c0a5b9d86509eaf&end=aa4cfd0809064503c69795e8e83ad067ad9e11a1&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:----:|:------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.5%] | 7 |
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.5%] | 5 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.3% | [0.2%, 0.5%] | 7 |
- https://github.com/rust-lang/rust/pull/134424#issuecomment-2628695885


Add a couple of missing `ensure_sufficient_stacks` [#136352](https://github.com/rust-lang/rust/pull/136352) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a5db378dc14a40dd1580c27fb8362156446382c3&end=f2c4ccd852f68fb36dedc033239cb7c0fb1921ef&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:----:|:------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.3%] | 12 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | - | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
- https://github.com/rust-lang/rust/pull/136352#issuecomment-2633158239


#### Improvements

Apply LTO config to rustdoc [#135832](https://github.com/rust-lang/rust/pull/135832) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fdd1a3b02687817cea41f6bacae3d5fbed2b2cd0&end=77a455303bf08da8eef6236b2b4422a77cd25c42&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | -0.3% | [-0.6%, -0.2%] | 9 |
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.4%, -0.2%] | 4 |
| All ❌✅ (primary) | -0.3% | [-0.6%, -0.2%] | 9 |


fix autodiff compile time regression [#136413](https://github.com/rust-lang/rust/pull/136413) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7daf4cf911c30e48c78f5e155c029397fdd82392&end=a5db378dc14a40dd1580c27fb8362156446382c3&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:------:|:----------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | -30.3% | [-30.6%, -29.7%] | 4 |
| Improvements ✅ <br /> (secondary) | -30.1% | [-32.0%, -28.2%] | 2 |
| All ❌✅ (primary) | -30.3% | [-30.6%, -29.7%] | 4 |


#### Mixed

Rollup of 8 pull requests [#136185](https://github.com/rust-lang/rust/pull/136185) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=aa6f5ab18e67cb815f73e0d53d217bc54b0da924&end=fdd1a3b02687817cea41f6bacae3d5fbed2b2cd0&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | 0.7% | [0.2%, 1.6%] | 3 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.8%, -0.4%] | 6 |
| All ❌✅ (primary) | - | - | 0 |
* https://github.com/rust-lang/rust/pull/136185#issuecomment-2635291385


Revert #135914: Remove usages of `QueryNormalizer` in the compiler [#136011](https://github.com/rust-lang/rust/pull/136011) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=aeba3c60f506218396883cb57812de2f3e067112&end=122fb29eb639aae852b9dcba0fd7aefc691be118&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:---------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.3%] | 16 |
| Improvements ✅ <br /> (primary) | -0.4% | [-1.1%, -0.2%] | 24 |
| Improvements ✅ <br /> (secondary) | -5.9% | [-10.4%, -0.9%] | 10 |
| All ❌✅ (primary) | -0.4% | [-1.1%, -0.2%] | 24 |
- https://github.com/rust-lang/rust/pull/136011#issuecomment-2635292874


Rollup of 9 pull requests [#136318](https://github.com/rust-lang/rust/pull/136318) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a730edcd67c7cb29d4458e170d4eb290387c27c3&end=6c1d960d88dd3755548b3818630acb63fa98187e&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.3% | [0.1%, 0.4%] | 8 |
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 1 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 2 |
| All ❌✅ (primary) | 0.3% | [0.1%, 0.4%] | 8 |
- It appears that #136180 is the culprit for this regression. I'm not sure it's worth addressing though.


Rollup of 9 pull requests [#136332](https://github.com/rust-lang/rust/pull/136332) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=25a16572a36321deae83546b63f5595d75361179&end=7f36543a48e52912ac6664a70c0a5b9d86509eaf&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | 43.3% | [42.1%, 44.0%] | 4 |
| Regressions ❌ <br /> (secondary) | 42.8% | [39.0%, 46.6%] | 2 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.2%] | 4 |
| All ❌✅ (primary) | 43.3% | [42.1%, 44.0%] | 4 |
- Fixed by https://github.com/rust-lang/rust/pull/136413


Rollup of 6 pull requests [#136389](https://github.com/rust-lang/rust/pull/136389) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e08cd3cf05e5bfa3323cc21ea8f81f4a15a2f969&end=8239a37f9c0951a037cfc51763ea52a20e71e6bd&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.1% | [0.1%, 0.1%] | 1 |
| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 0.5%] | 2 |
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.1%] | 2 |
| All ❌✅ (primary) | -0.1% | [-0.3%, 0.1%] | 2 |
- Perf is a wash so I don't think it's worth investigating.
Loading