Skip to content

Make compare page slightly less misleading when there are no relevant results #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Make compare page slightly less misleading when there are no relevant results #2045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
512909e
Hide main summary table when there are no results to show
Kobzol Feb 19, 2025
5c27a55
Guide users towards enabling `Filters -> Non-relevant results` when o…
Kobzol Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion site/frontend/src/pages/compare/compile/table/comparisons-table.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ const unit = computed(() => {
<div class="bench-table" :id="id">
<slot name="header"></slot>
<div v-if="comparisons.length === 0" style="text-align: center">
{{ hasNonRelevant ? "No relevant results" : "No results" }}
{{
hasNonRelevant
? "No relevant results (enable Filters -> Show non-relevant results to see all)"
: "No results"
}}
</div>
<table v-else class="benches compare">
<thead>
Expand Down
2 changes: 1 addition & 1 deletion site/frontend/src/pages/compare/summary/overall-summary.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const summary = computed(() => props.summary);
</script>

<template>
<div class="main-summary">
<div class="main-summary" v-if="summary.all.count > 0">
<SummaryTable :summary="summary"></SummaryTable>
<div style="position: absolute; right: 5px; top: 5px">
<Tooltip style="margin-right: 1em">
Expand Down
Loading