Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Apr 28, 2025

The exa crate is no longer maintained, it has been replaced with the eza fork. I had to remove the lib.rs file, because rustc-perf can't deal with crates that have both a library and a binary default target.

The crate is now much larger and takes longer to compile:
image

time -p CARGO_INCREMENTAL=0 cargo check ; cargo clean
# 8.09
# 20.10

time -p CARGO_INCREMENTAL=0 cargo build ; cargo clean
# 9.37
# 30.94

time -p CARGO_INCREMENTAL=0 cargo build --release ; cargo clean
# 26.22
# 73.31

Related issue: #2024

@Kobzol Kobzol added the benchmark-update PR that updates the benchmark set. label Apr 28, 2025
@Kobzol Kobzol requested a review from nnethercote April 28, 2025 08:11
@Kobzol Kobzol mentioned this pull request Apr 28, 2025
40 tasks
@nnethercote
Copy link
Contributor

The crate is now much larger and takes longer to compile

Seems to be a running theme...

There's an EUPL? Huh.

Why remove the CoC?

@Kobzol
Copy link
Member Author

Kobzol commented Apr 29, 2025

The CoC was licensed under a different license that we didn't yet have in this repo, so I'd have to add it to the LICENSES directory. Seemed easier to just remove the file. But if you think we shouldn't modify the repo I can add it back with the license.

@nnethercote
Copy link
Contributor

Yeah, adding the license is probably better, shouldn't be that hard.

@Kobzol Kobzol force-pushed the benchmark-update-2025-eza branch from b8f1c4a to ab8e7d5 Compare April 29, 2025 14:08
@Kobzol
Copy link
Member Author

Kobzol commented Apr 29, 2025

Ok, added the missing licenses.

@Kobzol Kobzol enabled auto-merge April 29, 2025 14:11
@Kobzol Kobzol merged commit e2bab11 into rust-lang:master Apr 29, 2025
11 checks passed
@Kobzol Kobzol deleted the benchmark-update-2025-eza branch April 29, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark-update PR that updates the benchmark set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants