From ed109cf82eea5f002f2edea253ca9e9950436e19 Mon Sep 17 00:00:00 2001 From: Miikka Salminen Date: Thu, 5 Jun 2025 16:14:02 +0300 Subject: [PATCH 1/4] Shorten the bot's elaboration text in try run comment --- site/src/github/comparison_summary.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/site/src/github/comparison_summary.rs b/site/src/github/comparison_summary.rs index 298a0479b..e40c965ab 100644 --- a/site/src/github/comparison_summary.rs +++ b/site/src/github/comparison_summary.rs @@ -404,11 +404,10 @@ fn try_run_body(is_regression: bool) -> String { let sign = if is_regression { "+" } else { "-" }; format!( " -Benchmarking this pull request likely means that it is \ -perf-sensitive, so we're automatically marking it as not fit \ -for rolling up. While you can manually mark this PR as fit \ -for rollup, we strongly recommend not doing so since this PR may lead to changes in \ -compiler perf.{next_steps} +Benchmarking this pull request means it may be perf-sensitive – \ +we'll automatically label it not fit for rolling up. \ +You can override this, but we strongly advise not to, \ +due to possible changes in compiler perf.{next_steps} @bors rollup=never @rustbot label: -S-waiting-on-perf {sign}perf-regression", From 9a690ffa8860bffa42764fced97ffe4873192568 Mon Sep 17 00:00:00 2001 From: Miikka Salminen Date: Thu, 5 Jun 2025 16:20:24 +0300 Subject: [PATCH 2/4] Shorten the bot's next step instructions in try run comment --- site/src/github/comparison_summary.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/site/src/github/comparison_summary.rs b/site/src/github/comparison_summary.rs index e40c965ab..6d1b63654 100644 --- a/site/src/github/comparison_summary.rs +++ b/site/src/github/comparison_summary.rs @@ -392,11 +392,10 @@ cc @rust-lang/wg-compiler-performance fn try_run_body(is_regression: bool) -> String { let next_steps = if is_regression { "\n\n**Next Steps**: If you can justify the regressions found in \ - this try perf run, please indicate this with \ - `@rustbot label: +perf-regression-triaged` along with \ - sufficient written justification. If you cannot justify the regressions \ - please fix the regressions and do another perf run. If the next run \ - shows neutral or positive results, the label will be automatically removed." + this try perf run, please do so in sufficient writing \ + along with `@rustbot label: +perf-regression-triaged`. If not, \ + please fix the regressions and do another perf run. If its results \ + are neutral or positive, we'll automatically remove the label." } else { "" }; From 1b7953b4cddf8e618a3978dd7e21ca60765f5c75 Mon Sep 17 00:00:00 2001 From: Miikka Salminen Date: Thu, 5 Jun 2025 16:26:56 +0300 Subject: [PATCH 3/4] Shorten the bot's most/less reliable metric help texts --- site/src/github/comparison_summary.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/site/src/github/comparison_summary.rs b/site/src/github/comparison_summary.rs index 6d1b63654..627f43cd4 100644 --- a/site/src/github/comparison_summary.rs +++ b/site/src/github/comparison_summary.rs @@ -325,8 +325,8 @@ fn write_metric_summary( match visibility { DefaultMetricVisibility::Shown => { message.push_str( - "This is the most reliable metric that we have; it was used to determine the \ - overall result at the top of this comment. However, even this metric can sometimes exhibit noise.\n\n", + "Our most reliable metric. Used to determine the overall result above. \ + However, even this metric can be noisy.\n\n", ); write_summary_table(&primary, &secondary, false, message); } @@ -351,8 +351,8 @@ fn write_metric_summary( // `
` means it is hidden, requiring a click to reveal. message.push_str(&format!("
\n{summary}\n\n")); message.push_str( - "This is a less reliable metric that may be of interest but was not \ - used to determine the overall result at the top of this comment.\n\n", + "A less reliable metric. May be of interest, but not \ + used to determine the overall result above.\n\n", ); write_summary_table(&primary, &secondary, false, message); message.push_str("
\n"); From 740000eca68bc00eae13e6258cf10cd598953aab Mon Sep 17 00:00:00 2001 From: Miikka Salminen Date: Thu, 5 Jun 2025 20:39:44 +0300 Subject: [PATCH 4/4] Apply suggested change to bot's next step message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Jakub Beránek --- site/src/github/comparison_summary.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/github/comparison_summary.rs b/site/src/github/comparison_summary.rs index 627f43cd4..40c62ea5f 100644 --- a/site/src/github/comparison_summary.rs +++ b/site/src/github/comparison_summary.rs @@ -395,7 +395,7 @@ fn try_run_body(is_regression: bool) -> String { this try perf run, please do so in sufficient writing \ along with `@rustbot label: +perf-regression-triaged`. If not, \ please fix the regressions and do another perf run. If its results \ - are neutral or positive, we'll automatically remove the label." + are neutral or positive, the label will be automatically removed." } else { "" };