Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Jun 13, 2025

I changed it from nightly to 1.81.0 in February, but since then we bumped MSRV of the collector, so we have been running with an old collector for quite some time 🤦‍♂️ I wonder if we should error out if the compilation fails?

HEAD is now at 88542ee4 Merge pull request #2158 from Kobzol/bootstrap-disable-extended
info: syncing channel updates for '1.81.0-x86_64-unknown-linux-gnu'
1.81.0-x86_64-unknown-linux-gnu unchanged - rustc 1.81.0 (eeb90cda1 2024-09-04)
info: checking for self-update
error: rustc 1.81.0 is not supported by the following packages:
[email protected] requires rustc 1.85.0

@Kobzol Kobzol requested a review from Mark-Simulacrum June 13, 2025 06:24
@Mark-Simulacrum
Copy link
Member

I think erroring could make sense though without public logs is a bit painful (needs someone privileged to debug).

@Kobzol
Copy link
Member Author

Kobzol commented Jun 16, 2025

We would notice a failure quite soon if no benchmarks would be running, and I can debug these things usually quite quickly, so indeed it would be useful. But let's leave it like this for now and see if the new version works.

@Kobzol Kobzol merged commit 5236fe9 into rust-lang:master Jun 17, 2025
11 checks passed
@Kobzol Kobzol deleted the use-stable-compiler-for-collect branch June 17, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants