Skip to content

Make sure to run all clippy lints at warn level #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Make sure to run all clippy lints at warn level #2164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion collector/src/compile/execute/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,9 +329,21 @@ impl<'a> CargoProcess<'a> {
let mut cmd = self.base_command(self.cwd, cargo_subcommand);
cmd.arg("-p").arg(self.get_pkgid(self.cwd)?);
match self.profile {
Profile::Check | Profile::Clippy => {
Profile::Check => {
cmd.arg("--profile").arg("check");
}
Profile::Clippy => {
cmd.arg("--profile").arg("check");
// Make sure that we run all lints, or else would
// be pointless for allow-by-default lint benchmarks
// and would cause errors with deny-by-default lints.
//
// Note that this takes priority over inherited `-Aclippy::*`s
// and similar.
let mut rustflags = env::var("RUSTFLAGS").unwrap_or_default();
rustflags.push_str(" -Wclippy::all");
cmd.env("RUSTFLAGS", rustflags);
}
Profile::Debug => {}
Profile::Doc => {}
Profile::DocJson => {
Expand Down
Loading