-
Notifications
You must be signed in to change notification settings - Fork 162
Feat: Logic for finding the next request to be processed and tests #2166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Logic for finding the next request to be processed and tests #2166
Conversation
Kobzol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, but it would be best to discuss in sync I think.
|
I think we can discuss the sorting logic in sync, now that we can take a look at existing code. |
c0d4708 to
fcb6f17
Compare
Kobzol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, but it looks pretty closely to how I envisioned it. I was a bit confused by the comments about "30 days" in tests though.
7eb4fe9 to
5d8da27
Compare
|
Thank you! Please squash the commits and we can merge this. |
b68cdfc to
fbd79ff
Compare
benchmark_request
fbd79ff to
f64dbe8
Compare
Kobzol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Tees up the next request in the
benchmark_requesttable (does not create jobs in what will be thejob_queuetable.in_progressI think we should be ok? Though I can bring back the SQL version if needed.SiteCtxtthus split the sorting logic to;get_next_benchmark_request(...)waiting_for_parent, I'm a bit lost as to what the name should be so am very open to suggestions.waitingalong with some code comments about whatwaitingmeans for the different types of commits was the best I could think of however I held off