Skip to content

Conversation

@panstromek
Copy link
Contributor

@panstromek panstromek commented Jul 7, 2025

I'll finish this in the morning, I ran out of time today done

@panstromek panstromek changed the title WIP: First draft for 2025-07-07 triage WIP: Add2025-07-07 triage Jul 7, 2025
@panstromek panstromek changed the title WIP: Add2025-07-07 triage WIP: Add 2025-07-07 triage Jul 7, 2025
@panstromek panstromek changed the title WIP: Add 2025-07-07 triage Add 2025-07-07 triage Jul 8, 2025
@panstromek panstromek marked this pull request as ready for review July 8, 2025 07:44

**Summary**:

Note: We switched to a new benchmark machine at the begining of the period. We show summary based on slightly adjusted range [6988a8fe..8df4a58a](https://perf.rust-lang.org/?start=6988a8fea774a2a20ebebddb7dbf15dd6ef594f9&end=8df4a58ac47b778b093652d6190a6f9d54638774&absolute=false&stat=instructions%3Au) to avoid misleading comparisons from different machines.
Copy link
Contributor Author

@panstromek panstromek Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this range is not exactly what I wanted (I wanted it to start on ByteSymbol and end with 0d11be5a (the same commit as the original range), but for some reason, the triage script outputs this range even if I set end explicitly to 0d11be5a.

It's two commits off, though and I don't have more time to dig into this, so I hope that's good enough

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, that's fine.

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️ This was really a complex week to deal with.


**Summary**:

Note: We switched to a new benchmark machine at the begining of the period. We show summary based on slightly adjusted range [6988a8fe..8df4a58a](https://perf.rust-lang.org/?start=6988a8fea774a2a20ebebddb7dbf15dd6ef594f9&end=8df4a58ac47b778b093652d6190a6f9d54638774&absolute=false&stat=instructions%3Au) to avoid misleading comparisons from different machines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, that's fine.

@Kobzol Kobzol merged commit 62972dc into master Jul 8, 2025
11 checks passed
@Kobzol Kobzol deleted the panstromek-patch-1 branch July 8, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants