Chore; make tag optional for Try benchmark requests
#2196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamesbarford
force-pushed
the
chore/modify-try-commit-type
branch
from
e11852c to
d45534b
Compare
Kobzol
reviewed
Jul 8, 2025
Kobzol
reviewed
Jul 8, 2025
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
Thanks! I tried it locally, the migration was applied cleanly, it allows inserting NULL SHAs, multiple non-completed try builds cannot exist at the same time, but multiple release builds can (so NULL in the pr column is treated as distinct values for the unique index). So it seems to work as we wanted it to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
benchmark_requestconstraint fortagto beNOT NULL.tag()to returnOption<&str>