Move to the 2024 edition

Author: bjorn3

Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "rustc_codegen_cranelift"
 version = "0.1.0"
-edition = "2021"
+edition = "2024"
 
 [lib]
 crate-type = ["dylib"]

src/abi/mod.rs

@@ -268,7 +268,7 @@ pub(crate) fn codegen_fn_prelude<'tcx>(fx: &mut FunctionCx<'_, '_, 'tcx>, start_
                 // individual function arguments.
 
                 let tupled_arg_tys = match arg_ty.kind() {
-                    ty::Tuple(ref tys) => tys,
+                    ty::Tuple(tys) => tys,
                     _ => bug!("spread argument isn't a tuple?! but {:?}", arg_ty),
                 };
 
@@ -491,7 +491,7 @@ pub(crate) fn codegen_terminator_call<'tcx>(
         };
 
         let tupled_arguments = match pack_arg.value.layout().ty.kind() {
-            ty::Tuple(ref tupled_arguments) => tupled_arguments,
+            ty::Tuple(tupled_arguments) => tupled_arguments,
             _ => bug!("argument to function with \"rust-call\" ABI is not a tuple"),
         };
 

src/base.rs

@@ -382,7 +382,7 @@ fn codegen_fn_body(fx: &mut FunctionCx<'_, '_, '_>, start_block: Block) {
                 fx.bcx.ins().nop();
 
                 match &**msg {
-                    AssertKind::BoundsCheck { ref len, ref index } => {
+                    AssertKind::BoundsCheck { len, index } => {
                         let len = codegen_operand(fx, len).load_scalar(fx);
                         let index = codegen_operand(fx, index).load_scalar(fx);
                         let location = fx.get_caller_location(source_info).load_scalar(fx);
@@ -395,7 +395,7 @@ fn codegen_fn_body(fx: &mut FunctionCx<'_, '_, '_>, start_block: Block) {
                             source_info.span,
                         );
                     }
-                    AssertKind::MisalignedPointerDereference { ref required, ref found } => {
+                    AssertKind::MisalignedPointerDereference { required, found } => {
                         let required = codegen_operand(fx, required).load_scalar(fx);
                         let found = codegen_operand(fx, found).load_scalar(fx);
                         let location = fx.get_caller_location(source_info).load_scalar(fx);
@@ -977,7 +977,7 @@ fn codegen_stmt<'tcx>(fx: &mut FunctionCx<'_, '_, 'tcx>, cur_block: Block, stmt:
         | StatementKind::AscribeUserType(..) => {}
 
         StatementKind::Coverage { .. } => unreachable!(),
-        StatementKind::Intrinsic(ref intrinsic) => match &**intrinsic {
+        StatementKind::Intrinsic(intrinsic) => match &**intrinsic {
             // We ignore `assume` intrinsics, they are only useful for optimizations
             NonDivergingIntrinsic::Assume(_) => {}
             NonDivergingIntrinsic::CopyNonOverlapping(mir::CopyNonOverlapping {

src/compiler_builtins.rs

@@ -18,7 +18,7 @@ macro_rules! builtin_functions {
     ) => {
         #[cfg(feature = "jit")]
         #[allow(improper_ctypes)]
-        extern "C" {
+        unsafe extern "C" {
             $(
                 $(#[$attr])?
                 fn $name($($arg_name: $arg_ty),*) -> $ret_ty;

src/constant.rs

@@ -576,7 +576,7 @@ pub(crate) fn mir_operand_get_const_val<'tcx>(
                         {
                             return None;
                         }
-                        StatementKind::Intrinsic(ref intrinsic) => match **intrinsic {
+                        StatementKind::Intrinsic(intrinsic) => match **intrinsic {
                             NonDivergingIntrinsic::CopyNonOverlapping(..) => return None,
                             NonDivergingIntrinsic::Assume(..) => {}
                         },

src/debuginfo/emit.rs

@@ -96,7 +96,7 @@ impl WriterRelocate {
                         if jit_module.declarations().get_function_decl(func_id).name.as_deref()
                             == Some("rust_eh_personality")
                         {
-                            extern "C" {
+                            unsafe extern "C" {
                                 fn rust_eh_personality() -> !;
                             }
                             rust_eh_personality as *const u8

src/debuginfo/unwind.rs

@@ -279,7 +279,7 @@ impl UnwindContext {
         // Everything after this line up to the end of the file is loosely based on
         // https://github.com/bytecodealliance/wasmtime/blob/4471a82b0c540ff48960eca6757ccce5b1b5c3e4/crates/jit/src/unwind/systemv.rs
         #[cfg(target_os = "macos")]
-        {
+        unsafe {
             // On macOS, `__register_frame` takes a pointer to a single FDE
             let start = eh_frame.as_ptr();
             let end = start.add(eh_frame.len());
@@ -301,12 +301,12 @@ impl UnwindContext {
         #[cfg(not(target_os = "macos"))]
         {
             // On other platforms, `__register_frame` will walk the FDEs until an entry of length 0
-            __register_frame(eh_frame.as_ptr());
+            unsafe { __register_frame(eh_frame.as_ptr()) };
         }
     }
 }
 
-extern "C" {
+unsafe extern "C" {
     // libunwind import
     fn __register_frame(fde: *const u8);
 }

src/lib.rs

@@ -382,7 +382,7 @@ fn build_isa(sess: &Session, jit: bool) -> Arc<dyn TargetIsa + 'static> {
 }
 
 /// This is the entrypoint for a hot plugged rustc_codegen_cranelift
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub fn __rustc_codegen_backend() -> Box<dyn CodegenBackend> {
     Box::new(CraneliftCodegenBackend { config: None })
 }