Support comments in trait bounds #5059
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And here I was thinking that splitting it up would make for smaller/simpler PRs 😁 I've taken a very cursory pass through this and think I follow your line of thinking around the solution. Will want to let it digest a bit and take a couple more passes through it, but I do have two smaller asks for now:
|
ytmimi
added
p-medium
pr-merge-conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've split out the portion of #5004 that fixes #2055 into its own PR.
I took a look at #4666 and found a case that it handled that wasn't in my original PR (handling comments before the trait identifier). I've updated the code and tests to include that.
It was also suggested over there that I take a look at the
rustfmt-2.0.0-rc.2for anything that might be related. The changes made in 27d5871 are the closest I came across. If it seems appropriate, I can update this PR to include the changes in that commit modified to switch onVersion::Two.