fix(cli): Style CLI errors in init mode

epage · rami3l · commit 2bccc3f1381f · 2026-03-03T19:57:58.000Z
By rolling back `tracing-subscriber` for now Fixes #4731
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -100,7 +100,9 @@ toml = "1.0"
 tracing = "0.1"
 tracing-log = "0.2"
 tracing-opentelemetry = { version = "0.32", optional = true }
-tracing-subscriber = { version = "0.3.16", features = ["env-filter"] }
+# Newer versions render ANSI escape codes, causing CLI errors to be ugly
+# See also https://github.com/tokio-rs/tracing/issues/3369
+tracing-subscriber = { version = "=0.3.19", features = ["env-filter"] }
 url = "2.4"
 wait-timeout = "0.2"
 xz2 = "0.1.3"
diff --git a/tests/suite/cli_rustup_ui/rustup_init_unknown_arg.stderr.term.svg b/tests/suite/cli_rustup_ui/rustup_init_unknown_arg.stderr.term.svg
@@ -1,8 +1,13 @@
-<svg width="810px" height="146px" xmlns="http://www.w3.org/2000/svg">
+<svg width="740px" height="146px" xmlns="http://www.w3.org/2000/svg">
   <style>
     .fg { fill: #AAAAAA }
     .bg { fill: #000000 }
+    .fg-bright-cyan { fill: #55FFFF }
+    .fg-bright-green { fill: #55FF55 }
+    .fg-bright-red { fill: #FF5555 }
+    .fg-cyan { fill: #00AAAA }
     .fg-red { fill: #AA0000 }
+    .fg-yellow { fill: #AA5500 }
     .container {
       padding: 0 10px;
       line-height: 18px;
@@ -18,15 +23,15 @@
   <rect width="100%" height="100%" y="0" rx="4.5" class="bg" />
 
   <text xml:space="preserve" class="container fg">
-    <tspan x="10px" y="28px"><tspan class="fg-red bold">error:</tspan><tspan> /x1b[1m/x1b[91merror:/x1b[0m unexpected argument '/x1b[1m/x1b[33m--random/x1b[0m' found</tspan>
+    <tspan x="10px" y="28px"><tspan class="fg-red bold">error:</tspan><tspan> </tspan><tspan class="fg-bright-red bold">error:</tspan><tspan> unexpected argument '</tspan><tspan class="fg-yellow bold">--random</tspan><tspan>' found</tspan>
 </tspan>
     <tspan x="10px" y="46px">
 </tspan>
-    <tspan x="10px" y="64px"><tspan>/x1b[1m/x1b[92mUsage:/x1b[0m /x1b[1m/x1b[96mrustup-init[EXE]/x1b[0m /x1b[36m[OPTIONS]/x1b[0m</tspan>
+    <tspan x="10px" y="64px"><tspan class="fg-bright-green bold">Usage:</tspan><tspan> </tspan><tspan class="fg-bright-cyan bold">rustup-init[EXE]</tspan><tspan> </tspan><tspan class="fg-cyan">[OPTIONS]</tspan>
 </tspan>
     <tspan x="10px" y="82px">
 </tspan>
-    <tspan x="10px" y="100px"><tspan>For more information, try '/x1b[1m/x1b[96m--help/x1b[0m'.</tspan>
+    <tspan x="10px" y="100px"><tspan>For more information, try '</tspan><tspan class="fg-bright-cyan bold">--help</tspan><tspan>'.</tspan>
 </tspan>
     <tspan x="10px" y="118px">
 </tspan>
