fix(downloads): correct faulty output when retrying a download

The `DownloadFinished` notification was always being called even if the
download was unsuccessful. This would confuse the DownloadTracker as to
the download really ended (successfully).

To fix this, the notification is now only thrown iff the download didn't
timeout. This could be (possibly) accompanied by a new notification, say
`DownloadTimedOut` but it wouldn't have any direct use yet, so I refrain
from adding it.

Author: FranciscoTGouveia

src/cli/download_tracker.rs

@@ -59,6 +59,7 @@ impl DownloadTracker {
                 self.create_progress_bar(component.to_owned(), url.to_owned());
                 true
             }
+            Notification::Install(In::RetryingDownload(_url)) => true,
             _ => false,
         }
     }

src/download/mod.rs

@@ -218,7 +218,10 @@ async fn download_file_(
         .download_to_path(url, path, resume_from_partial, Some(callback), timeout)
         .await;
 
-    notify_handler(Notification::DownloadFinished(Some(url.as_str())));
+    // The notification should only be sent if the download was successful (i.e. didn't timeout)
+    if res.is_ok() {
+        notify_handler(Notification::DownloadFinished(Some(url.as_str())));
+    }
 
     res
 }