notifications: log directly for valid checksums

Author: djc

src/dist/download.rs

@@ -4,6 +4,7 @@ use std::path::{Path, PathBuf};
 
 use anyhow::{Context, Result, anyhow};
 use sha2::{Digest, Sha256};
+use tracing::debug;
 use url::Url;
 
 use crate::dist::temp;
@@ -50,7 +51,7 @@ impl<'a> DownloadCfg<'a> {
             let cached_result = file_hash(&target_file, self.notify_handler)?;
             if hash == cached_result {
                 (self.notify_handler)(Notification::FileAlreadyDownloaded);
-                (self.notify_handler)(Notification::ChecksumValid(url.as_ref()));
+                debug!(url = url.as_ref(), "checksum passed");
                 return Ok(File { path: target_file });
             } else {
                 (self.notify_handler)(Notification::CachedFileChecksumFailed);
@@ -105,8 +106,7 @@ impl<'a> DownloadCfg<'a> {
                 .into())
             }
         } else {
-            (self.notify_handler)(Notification::ChecksumValid(url.as_ref()));
-
+            debug!(url = url.as_ref(), "checksum passed");
             utils::rename("downloaded", &partial_file_path, &target_file, self.process)?;
             Ok(File { path: target_file })
         }
@@ -190,7 +190,7 @@ impl<'a> DownloadCfg<'a> {
             }
             .into());
         } else {
-            (self.notify_handler)(Notification::ChecksumValid(url_str));
+            debug!(url = url_str, "checksum passed");
         }
 
         Ok(Some((file, partial_hash)))

src/notifications.rs

@@ -14,7 +14,6 @@ pub(crate) enum Notification<'a> {
     ComponentAlreadyInstalled(&'a str),
     CantReadUpdateHash(&'a Path),
     NoUpdateHash(&'a Path),
-    ChecksumValid(&'a str),
     FileAlreadyDownloaded,
     CachedFileChecksumFailed,
     MissingInstalledComponent(&'a str),
@@ -75,10 +74,9 @@ impl Notification<'_> {
     pub(crate) fn level(&self) -> NotificationLevel {
         use self::Notification::*;
         match self {
-            ChecksumValid(_)
-            | NoUpdateHash(_)
-            | FileAlreadyDownloaded
-            | DownloadingLegacyManifest => NotificationLevel::Debug,
+            NoUpdateHash(_) | FileAlreadyDownloaded | DownloadingLegacyManifest => {
+                NotificationLevel::Debug
+            }
             DownloadingComponent(_, _, _, _)
             | InstallingComponent(_, _, _)
             | RemovingComponent(_, _, _)
@@ -134,7 +132,6 @@ impl Display for Notification<'_> {
                 path.display()
             ),
             NoUpdateHash(path) => write!(f, "no update hash at: '{}'", path.display()),
-            ChecksumValid(url) => write!(f, "checksum passed for {url}"),
             FileAlreadyDownloaded => write!(f, "reusing previously downloaded file"),
             CachedFileChecksumFailed => write!(f, "bad checksum for cached download"),
             MissingInstalledComponent(c) => {