Introduce RUSTUP_DOWNLOAD_TIMEOUT to override the download timeout
#4440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
reviewed
Aug 10, 2025
FranciscoTGouveia
force-pushed
the
download-timeout
branch
from
bf699dd to
d19ffb2
Compare
djc
reviewed
Aug 12, 2025
rami3l
reviewed
Aug 12, 2025
FranciscoTGouveia
force-pushed
the
download-timeout
branch
from
d19ffb2 to
f22b590
Compare
This change is needed to allow us to pass an argument for the creation of the client, as it is being done in `rustls_client()`.
FranciscoTGouveia
force-pushed
the
download-timeout
branch
from
f22b590 to
31c31d8
Compare
rami3l
approved these changes
Aug 14, 2025
…ng download timeout As some (corporate) firewalls take too much time to verify the downloads, the timeout is reached and the user cannot complete its installation. Besides changing the timeout from 30 secs to 3 mins, a new environment variable is introduced to allow users to override the timeout value to their taste.
FranciscoTGouveia
force-pushed
the
download-timeout
branch
from
31c31d8 to
6b358bb
Compare
djc
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4439.
Besides increasing the default timeout from 30 seconds to 3 minutes, a new environment variable (
RUSTUP_DOWNLOAD_TIMEOUT) is introduced to allow users to override this value.