Skip to content

Commit a5a4cfc

Browse files
committed
Rename Runner::build to Runner::run and re-introduce Runner::build
1 parent d7f267d commit a5a4cfc

File tree

2 files changed

+17
-9
lines changed

2 files changed

+17
-9
lines changed

tests/buildtest/mod.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ mod inside_docker;
99
#[test]
1010
fn test_hello_world() {
1111
runner::run("hello-world", |run| {
12-
run.build(SandboxBuilder::new().enable_networking(false), |build| {
12+
run.run(SandboxBuilder::new().enable_networking(false), |build| {
1313
let storage = rustwide::logging::LogStorage::new(LevelFilter::Info);
1414
rustwide::logging::capture(&storage, || -> Result<_, Error> {
1515
build.cargo().args(&["run"]).run()?;
@@ -29,7 +29,7 @@ fn test_hello_world() {
2929
#[test]
3030
fn test_process_lines() {
3131
runner::run("process-lines", |run| {
32-
run.build(SandboxBuilder::new().enable_networking(false), |build| {
32+
run.run(SandboxBuilder::new().enable_networking(false), |build| {
3333
let storage = rustwide::logging::LogStorage::new(LevelFilter::Info);
3434
let mut ex = false;
3535
rustwide::logging::capture(&storage, || -> Result<_, Error> {
@@ -64,7 +64,7 @@ fn test_sandbox_oom() {
6464
use rustwide::cmd::CommandError;
6565

6666
runner::run("out-of-memory", |run| {
67-
let res = run.build(
67+
let res = run.run(
6868
SandboxBuilder::new()
6969
.enable_networking(false)
7070
.memory_limit(Some(512 * 1024 * 1024)),
@@ -85,7 +85,7 @@ fn test_sandbox_oom() {
8585
#[test]
8686
fn test_override_files() {
8787
runner::run("cargo-config", |run| {
88-
run.build(SandboxBuilder::new().enable_networking(false), |build| {
88+
run.run(SandboxBuilder::new().enable_networking(false), |build| {
8989
let storage = rustwide::logging::LogStorage::new(LevelFilter::Info);
9090
rustwide::logging::capture(&storage, || -> Result<_, Error> {
9191
build.cargo().args(&["--version"]).run()?;
@@ -104,7 +104,7 @@ fn test_override_files() {
104104
#[test]
105105
fn test_cargo_workspace() {
106106
runner::run("cargo-workspace", |run| {
107-
run.build(SandboxBuilder::new().enable_networking(false), |build| {
107+
run.run(SandboxBuilder::new().enable_networking(false), |build| {
108108
let storage = rustwide::logging::LogStorage::new(LevelFilter::Info);
109109
rustwide::logging::capture(&storage, || -> Result<_, Error> {
110110
build.cargo().args(&["run"]).run()?;

tests/buildtest/runner.rs

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use failure::Error;
2-
use rustwide::{cmd::SandboxBuilder, Build, Crate, Toolchain, Workspace};
2+
use rustwide::{cmd::SandboxBuilder, Build, BuildBuilder, Crate, Toolchain, Workspace};
33
use std::path::Path;
44

55
pub(crate) fn run(crate_name: &str, f: impl FnOnce(&mut Runner) -> Result<(), Error>) {
@@ -38,11 +38,19 @@ impl Runner {
3838
pub(crate) fn build<T>(
3939
&self,
4040
sandbox: SandboxBuilder,
41-
f: impl FnOnce(&Build) -> Result<T, Error>,
41+
f: impl FnOnce(BuildBuilder) -> Result<T, Error>,
4242
) -> Result<T, Error> {
4343
let mut dir = self.workspace.build_dir(&self.crate_name);
4444
dir.purge()?;
45-
dir.build(&self.toolchain, &self.krate, sandbox).run(f)
45+
f(dir.build(&self.toolchain, &self.krate, sandbox))
46+
}
47+
48+
pub(crate) fn run<T>(
49+
&self,
50+
sandbox: SandboxBuilder,
51+
f: impl FnOnce(&Build) -> Result<T, Error>,
52+
) -> Result<T, Error> {
53+
self.build(sandbox, |builder| builder.run(f))
4654
}
4755
}
4856

@@ -51,7 +59,7 @@ macro_rules! test_prepare_error {
5159
#[test]
5260
fn $name() {
5361
runner::run($krate, |run| {
54-
let res = run.build(
62+
let res = run.run(
5563
rustwide::cmd::SandboxBuilder::new().enable_networking(false),
5664
|_| Ok(()),
5765
);

0 commit comments

Comments
 (0)