RISC-V: Lower requirements of clmul and clmulh
#1909
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updating the documentation would be better but considering many intrinsics refer older, separate documentation (before being merged into the main RISC-V ISA Manual), that would be better to be a separate PR. |
a4lg
force-pushed
the
riscv-clmul-lower-requirements
branch
from
9eed1f8 to
afa57f9
Compare
|
Hmm, CI is failing for an unrelated reason. |
|
It's just that the |
a4lg
force-pushed
the
riscv-clmul-lower-requirements
branch
from
afa57f9 to
5b6ca89
Compare
|
Could you rebase thee branch pls, #1912 fixed the CI failure |
They don't need full "Zbc" extension but only its subset: the "Zbkc" extension. Since the compiler implies `zbkc` from `zbc`, it's safe to use `#[target_feature(enable = "zbkc")]`.
a4lg
force-pushed
the
riscv-clmul-lower-requirements
branch
from
5b6ca89 to
1207c2b
Compare
|
Thanks for letting me know. Rebased and force-pushed. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Merge failure occurred on RISC-V (RV32) but it seems it's just a connection issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They don't need full "Zbc" extension but only its subset: the "Zbkc" extension.
Since the compiler implies
zbkcfromzbc, it's safe to use#[target_feature(enable = "zbkc")].