Skip to content

Conversation

@nellshamrell
Copy link
Contributor

No description provided.

@andrewpollack
Copy link
Member

Pushed changes to this PR to shift all publishing shebangs to be bash

Copy link
Contributor

@mariannegoldin mariannegoldin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cdmistman
Copy link
Contributor

cdmistman commented Oct 3, 2024

I'm sorry I'm a little confused why this PR is open. What was broken with /bin/sh? /bin/sh should exist on all unix-compatible systems, but /bin/bash shouldn't be guaranteed to do so (love the unix ecosystem). i understand we're using an ubuntu docker image but want to make sure i understand the problem :)

@andrewpollack
Copy link
Member

@nellshamrell was running into issues with using source file.sh over the WSL of Linux, and resolution was to update this shebang. I dont have the hardware to confirm that this was independent of the issue, and will need to defer explanation beyond this

@nellshamrell
Copy link
Contributor Author

it did not work on WSL, and when I changed it it did work, that is my best explanation :)

@nellshamrell
Copy link
Contributor Author

Just confirmed that is still the case on my system - this appears to be necessary for use with WSL

@cdmistman cdmistman merged commit 854b6a2 into master Oct 10, 2024
2 checks passed
@cdmistman cdmistman deleted the fix-email-script branch October 10, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants