Merge pull request #1964 from Urgau/silence-reminder-for-member

Silence the `ready` reminder when the author is a member of repository

Author: Kobzol

src/github.rs

@@ -4,7 +4,7 @@ use bytes::Bytes;
 use chrono::{DateTime, FixedOffset, Utc};
 use futures::{future::BoxFuture, FutureExt};
 use hyper::header::HeaderValue;
-use octocrab::models::Author;
+use octocrab::models::{Author, AuthorAssociation};
 use regex::Regex;
 use reqwest::header::{AUTHORIZATION, USER_AGENT};
 use reqwest::{Client, Request, RequestBuilder, Response, StatusCode};
@@ -396,6 +396,9 @@ pub struct Issue {
     pub milestone: Option<Milestone>,
     /// Whether a PR has merge conflicts.
     pub mergeable: Option<bool>,
+
+    /// How the author is associated with the repository
+    pub author_association: AuthorAssociation,
 }
 
 #[derive(Debug, serde::Deserialize, Eq, PartialEq)]

src/handlers/shortcut.rs

@@ -9,6 +9,7 @@ use crate::{
     handlers::Context,
     interactions::ErrorComment,
 };
+use octocrab::models::AuthorAssociation;
 use parser::command::shortcut::ShortcutCommand;
 
 /// Key for the state in the database
@@ -65,7 +66,16 @@ pub(super) async fn handle_command(
     }
 
     // We add a small reminder for the author to use `@bot ready` when ready
-    if matches!(input, ShortcutCommand::Author) {
+    //
+    // Except if the author is a member (or the owner) of the repository, as
+    // the author should already know about the `ready` command and already
+    // have the required permissions to update the labels manually anyway.
+    if matches!(input, ShortcutCommand::Author)
+        && !matches!(
+            issue.author_association,
+            AuthorAssociation::Member | AuthorAssociation::Owner
+        )
+    {
         // Get the state of the author reminder for this PR
         let mut db = ctx.db.get().await;
         let mut state: IssueData<'_, AuthorReminderState> =

src/tests/github.rs

@@ -71,6 +71,7 @@ pub fn issue(
         state,
         milestone: None,
         mergeable: None,
+        author_association: octocrab::models::AuthorAssociation::None,
     }
 }