Skip to content

Commit 1fb66e7

Browse files
authored
Merge pull request #2060 from Kobzol/autoassign-special-case
Fix self-assign fast path
2 parents fcfefd0 + 9c1df0f commit 1fb66e7

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/handlers/assign.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,6 +397,7 @@ async fn determine_assignee(
397397
&teams,
398398
config,
399399
&event.issue,
400+
&event.issue.user.login,
400401
&[name],
401402
)
402403
.await
@@ -420,6 +421,7 @@ async fn determine_assignee(
420421
&teams,
421422
config,
422423
&event.issue,
424+
&event.issue.user.login,
423425
&candidates,
424426
)
425427
.await
@@ -461,6 +463,7 @@ async fn determine_assignee(
461463
&teams,
462464
config,
463465
&event.issue,
466+
&event.issue.user.login,
464467
fallback,
465468
)
466469
.await
@@ -645,6 +648,7 @@ pub(super) async fn handle_command(
645648
&teams,
646649
config,
647650
issue,
651+
&event.user().login,
648652
&[assignee.to_string()],
649653
)
650654
.await
@@ -871,11 +875,12 @@ async fn find_reviewer_from_names(
871875
teams: &Teams,
872876
config: &AssignConfig,
873877
issue: &Issue,
878+
requested_by: &str,
874879
names: &[String],
875880
) -> Result<ReviewerSelection, FindReviewerError> {
876881
// Fast path for self-assign, which is always allowed.
877882
if let [name] = names {
878-
if is_self_assign(&name, &issue.user.login) {
883+
if is_self_assign(&name, requested_by) {
879884
return Ok(ReviewerSelection::from_name(name.clone()));
880885
}
881886
}

0 commit comments

Comments
 (0)