clippy::ptr_arg

Author: ada4a

src/db.rs

@@ -257,11 +257,7 @@ pub async fn run_scheduled_jobs(ctx: &Context) -> anyhow::Result<()> {
 }
 
 // Try to handle a specific job
-async fn handle_job(
-    ctx: &Context,
-    name: &String,
-    metadata: &serde_json::Value,
-) -> anyhow::Result<()> {
+async fn handle_job(ctx: &Context, name: &str, metadata: &serde_json::Value) -> anyhow::Result<()> {
     for job in jobs() {
         if job.name() == name {
             return job.run(ctx, metadata).await;

src/db/jobs.rs

@@ -51,7 +51,7 @@ pub async fn delete_job(db: &DbClient, id: &Uuid) -> Result<()> {
     Ok(())
 }
 
-pub async fn update_job_error_message(db: &DbClient, id: &Uuid, message: &String) -> Result<()> {
+pub async fn update_job_error_message(db: &DbClient, id: &Uuid, message: &str) -> Result<()> {
     tracing::trace!("update_job_error_message(id={id})");
 
     db.execute(

src/gha_logs.rs

@@ -31,7 +31,7 @@ pub struct CachedLog {
 }
 
 impl GitHubActionLogsCache {
-    pub fn get(&mut self, key: &String) -> Option<Arc<CachedLog>> {
+    pub fn get(&mut self, key: &str) -> Option<Arc<CachedLog>> {
         if let Some(pos) = self.entries.iter().position(|(k, _)| k == key) {
             // Move previously cached entry to the front
             let entry = self.entries.remove(pos).unwrap();

src/github.rs

@@ -1472,8 +1472,8 @@ impl Repository {
     fn build_issues_url(
         &self,
         client: &GithubClient,
-        filters: &Vec<(&str, &str)>,
-        include_labels: &Vec<&str>,
+        filters: &[(&str, &str)],
+        include_labels: &[&str],
         ordering: Ordering<'_>,
     ) -> String {
         self.build_endpoint_url(client, "issues", filters, include_labels, ordering)
@@ -1482,8 +1482,8 @@ impl Repository {
     fn build_pulls_url(
         &self,
         client: &GithubClient,
-        filters: &Vec<(&str, &str)>,
-        include_labels: &Vec<&str>,
+        filters: &[(&str, &str)],
+        include_labels: &[&str],
         ordering: Ordering<'_>,
     ) -> String {
         self.build_endpoint_url(client, "pulls", filters, include_labels, ordering)
@@ -1493,8 +1493,8 @@ impl Repository {
         &self,
         client: &GithubClient,
         endpoint: &str,
-        filters: &Vec<(&str, &str)>,
-        include_labels: &Vec<&str>,
+        filters: &[(&str, &str)],
+        include_labels: &[&str],
         ordering: Ordering<'_>,
     ) -> String {
         let filters = filters
@@ -1515,9 +1515,9 @@ impl Repository {
     fn build_search_issues_url(
         &self,
         client: &GithubClient,
-        filters: &Vec<(&str, &str)>,
-        include_labels: &Vec<&str>,
-        exclude_labels: &Vec<&str>,
+        filters: &[(&str, &str)],
+        include_labels: &[&str],
+        exclude_labels: &[&str],
         ordering: Ordering<'_>,
     ) -> String {
         let filters = filters

src/handlers/assign/tests/tests_from_diff.rs

@@ -3,7 +3,7 @@
 use super::super::*;
 use std::fmt::Write;
 
-fn test_from_diff(diff: &Vec<FileDiff>, config: toml::Table, expected: &[&str]) {
+fn test_from_diff(diff: &[FileDiff], config: toml::Table, expected: &[&str]) {
     let aconfig: AssignConfig = config.try_into().unwrap();
     assert_eq!(
         find_reviewers_from_diff(&aconfig, &*diff).unwrap(),

src/handlers/check_commits.rs

@@ -290,10 +290,7 @@ fn warning_from_warnings(warnings: &[String]) -> String {
 }
 
 // Calculate the label changes
-fn calculate_label_changes(
-    previous: &Vec<String>,
-    current: &Vec<String>,
-) -> (Vec<String>, Vec<String>) {
+fn calculate_label_changes(previous: &[String], current: &[String]) -> (Vec<String>, Vec<String>) {
     let previous_set: HashSet<String> = previous.iter().cloned().collect();
     let current_set: HashSet<String> = current.iter().cloned().collect();
 
@@ -305,8 +302,8 @@ fn calculate_label_changes(
 
 // Calculate the error changes
 fn calculate_error_changes(
-    previous: &Vec<(String, String)>,
-    current: &Vec<String>,
+    previous: &[(String, String)],
+    current: &[String],
 ) -> (Vec<(String, String)>, Vec<String>) {
     let previous_set: HashSet<(String, String)> = previous.iter().cloned().collect();
     let current_set: HashSet<String> = current.iter().cloned().collect();

src/handlers/check_commits/no_merges.rs

@@ -12,7 +12,7 @@ pub(super) fn merges_in_commits(
     issue_title: &str,
     repository: &Repository,
     config: &NoMergesConfig,
-    commits: &Vec<GithubCommit>,
+    commits: &[GithubCommit],
 ) -> Option<(String, Vec<String>)> {
     // Don't trigger if the PR has any of the excluded title segments.
     if config
@@ -143,7 +143,7 @@ $ git push --force-with-lease
         let commit = dummy_commit_from_body("67c917fe5937e984f58f5003ccbb5c37e", "+ main.rs");
 
         assert_eq!(
-            merges_in_commits(&title, &repository, &config, &vec![commit]),
+            merges_in_commits(&title, &repository, &config, &[commit]),
             None
         );
     }
@@ -155,7 +155,7 @@ $ git push --force-with-lease
                 "Subtree update of rustc_custom_codegen",
                 &repository,
                 &config,
-                &vec![commit_with_merge()]
+                &[commit_with_merge()]
             ),
             None
         );