Skip to content

Commit 44b099c

Browse files
committed
Allow empty [assign.owners]
1 parent 7044e54 commit 44b099c

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/handlers/assign.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,7 @@ pub(super) async fn parse_input(
129129
event: &IssuesEvent,
130130
config: Option<&AssignConfig>,
131131
) -> Result<Option<AssignInput>, String> {
132-
let config = match config {
133-
Some(config) => config,
134-
None => return Ok(None),
135-
};
136-
if config.owners.is_empty() || !event.issue.is_pr() {
132+
if config.is_none() || !event.issue.is_pr() {
137133
return Ok(None);
138134
}
139135

src/handlers/assign/tests/tests_from_diff.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,3 +144,10 @@ fn basic_gitignore_pattern() {
144144
let diff = make_fake_diff(&[("src/librustdoc/html/static/js/settings.js", 10, 1)]);
145145
test_from_diff(&diff, config, &["javascript-reviewers"]);
146146
}
147+
148+
#[test]
149+
fn empty_owners_table() {
150+
let config = toml::toml!([owners]);
151+
let diff = make_fake_diff(&[("src.js", 10, 1)]);
152+
test_from_diff(&diff, config, &[]);
153+
}

0 commit comments

Comments
 (0)