Return 400 (bad request) instead of 500 (internal error) for some errors

Urgau · Urgau · commit 7d6773dcf914 · 2025-07-25T22:50:34.000+02:00
diff --git a/src/gha_logs.rs b/src/gha_logs.rs
@@ -100,11 +100,15 @@ async fn process_logs(
         .context("unable to retrieve team repos")?;
 
     let Some(repos) = repos.repos.get(owner) else {
-        anyhow::bail!("Organization `{owner}` is not part of team repos")
+        return Ok(bad_request(format!(
+            "organization `{owner}` is not part of the Rust Project team repos"
+        )));
     };
 
     if !repos.iter().any(|r| r.name == repo) {
-        anyhow::bail!("Repository `{repo}` is not part of team repos");
+        return Ok(bad_request(format!(
+            "repository `{owner}` is not part of the Rust Project team repos"
+        )));
     }
 
     let log_uuid = format!("{owner}/{repo}${log_id}");
@@ -345,3 +349,10 @@ pub fn failure_svg() -> anyhow::Result<Response<Body>, hyper::Error> {
         .body(Body::from(FAILURE_SVG))
         .unwrap())
 }
+
+fn bad_request(body: String) -> Response<Body> {
+    Response::builder()
+        .status(StatusCode::BAD_REQUEST)
+        .body(Body::from(body))
+        .unwrap()
+}
