Take RotationMode into account when performing reviews using [review_prefs]

Author: Kobzol

src/handlers/assign.rs

@@ -998,20 +998,22 @@ async fn candidate_reviewers_from_names<'a>(
                 let username = username?;
 
                 // If no review prefs were found, we assume the default unlimited
-                // review capacity.
+                // review capacity and being on rotation.
                 let Some(review_prefs) = review_prefs.get(username.as_str()) else {
                     return Ok(username);
                 };
-                let Some(capacity) = review_prefs.max_assigned_prs else {
-                    return Ok(username);
-                };
-                let assigned_prs = workqueue.assigned_pr_count(review_prefs.user_id as UserId);
-                // Can we assign one more PR?
-                if (assigned_prs as i32) < capacity {
-                    Ok(username)
-                } else {
-                    Err(FindReviewerError::ReviewerAtMaxCapacity { username })
+                if let Some(capacity) = review_prefs.max_assigned_prs {
+                    let assigned_prs = workqueue.assigned_pr_count(review_prefs.user_id as UserId);
+                    // Is the reviewer at max capacity?
+                    if (assigned_prs as i32) >= capacity {
+                        return Err(FindReviewerError::ReviewerAtMaxCapacity { username });
+                    }
+                }
+                if review_prefs.rotation_mode == RotationMode::OffRotation {
+                    return Err(FindReviewerError::ReviewerOffRotation { username });
                 }
+
+                return Ok(username);
             })
             .collect();
     }

src/handlers/assign/tests/tests_candidates.rs

@@ -243,6 +243,58 @@ async fn unlimited_capacity() {
     .await;
 }
 
+#[tokio::test]
+async fn ignore_user_off_rotation_direct() {
+    run_db_test(|ctx| async move {
+        let user = user("martin", 1);
+        review_prefs_test(ctx)
+            .set_review_prefs(&user, None, RotationMode::OffRotation)
+            .await
+            .check(
+                &["martin"],
+                Err(FindReviewerError::ReviewerOffRotation {
+                    username: "martin".to_string(),
+                }),
+            )
+            .await
+    })
+    .await;
+}
+
+#[tokio::test]
+async fn ignore_user_off_rotation_through_team() {
+    run_db_test(|ctx| async move {
+        let teams = toml::toml!(compiler = ["martin", "diana"]);
+        let user = user("martin", 1);
+        review_prefs_test(ctx)
+            .teams(&teams)
+            .set_review_prefs(&user, None, RotationMode::OffRotation)
+            .await
+            .check(&["compiler"], Ok(&["diana"]))
+            .await
+    })
+    .await;
+}
+
+#[tokio::test]
+async fn review_prefs_prefer_capacity_before_rotation() {
+    run_db_test(|ctx| async move {
+        let user = user("martin", 1);
+        review_prefs_test(ctx)
+            .set_review_prefs(&user, Some(1), RotationMode::OffRotation)
+            .await
+            .assign_prs(user.id, 2)
+            .check(
+                &["martin"],
+                Err(FindReviewerError::ReviewerAtMaxCapacity {
+                    username: "martin".to_string(),
+                }),
+            )
+            .await
+    })
+    .await;
+}
+
 #[tokio::test]
 async fn multiple_reviewers() {
     run_db_test(|ctx| async move {