Skip to content

Commit cb79f88

Browse files
committed
Follow review comments
1 parent 042a6be commit cb79f88

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/handlers/check_commits/no_mentions.rs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,11 @@ pub(super) fn mentions_in_commits(
88
conf: &NoMentionsConfig,
99
commits: &[GithubCommit],
1010
) -> Option<String> {
11-
if conf.exclude_titles.iter().any(|s| pr_title.contains(s)) {
11+
if conf
12+
.exclude_titles
13+
.iter()
14+
.any(|s| pr_title.to_lowercase().contains(&s.to_lowercase()))
15+
{
1216
return None;
1317
}
1418

@@ -73,7 +77,7 @@ Co-authored-by: Baz Qux <[email protected]>",
7377
);
7478

7579
commits.push(dummy_commit_from_body(
76-
"6565ffdd8af4ca0ec7c8faceee59c582edcd83b2",
80+
"4894129179b361200c9cd733ba0e906bf98747a2",
7781
"This is a body that mentions @rustbot for a command! And then a user @mention",
7882
));
7983

@@ -82,7 +86,7 @@ Co-authored-by: Baz Qux <[email protected]>",
8286
Some(
8387
r"There are username mentions (such as `@user`) in the commit messages of the following commits.
8488
*Please remove the mentions to avoid spamming these users.*
85-
- 6565ffdd8af4ca0ec7c8faceee59c582edcd83b2
89+
- 4894129179b361200c9cd733ba0e906bf98747a2
8690
".to_string()
8791
)
8892
);

0 commit comments

Comments
 (0)