Merge pull request #1945 from Urgau/issue_links-parent

Handle issue links in parenthesis

Author: Urgau

src/handlers/check_commits/issue_links.rs

@@ -5,7 +5,7 @@ use regex::Regex;
 use crate::{config::IssueLinksConfig, github::GithubCommit};
 
 static LINKED_RE: LazyLock<Regex> =
-    LazyLock::new(|| Regex::new(r"( |^)([a-zA-Z-_]+/[a-zA-Z-_]+)?(#[0-9]+)\b").unwrap());
+    LazyLock::new(|| Regex::new(r"\B([a-zA-Z-_]+/[a-zA-Z-_]+)?(#[0-9]+)\b").unwrap());
 
 const MERGE_IGNORE_LIST: [&str; 2] = ["Rollup merge of ", "Auto merge of "];
 
@@ -76,7 +76,7 @@ fn test_mentions_in_commits() {
 
     commits.push(dummy_commit_from_body(
         "891f0916a07c215ae8173f782251422f1fea6acb",
-        "This is a body with a issue link rust-lang/rust#123.",
+        "This is a body with a issue link (rust-lang/rust#123).",
     ));
 
     assert_eq!(

src/handlers/issue_links.rs

@@ -16,7 +16,7 @@ use crate::{
 };
 
 static LINKED_RE: LazyLock<Regex> =
-    LazyLock::new(|| Regex::new(r"(?P<start> |^)(?P<issue>#[0-9]+)\b").unwrap());
+    LazyLock::new(|| Regex::new(r"\B(?P<issue>#[0-9]+)\b").unwrap());
 
 pub(super) struct IssueLinksInput {}
 
@@ -63,7 +63,7 @@ pub(super) async fn handle_input(
 }
 
 fn fix_linked_issues<'a>(body: &'a str, full_repo_name: &str) -> Cow<'a, str> {
-    let replace_by = format!("${{start}}{full_repo_name}${{issue}}");
+    let replace_by = format!("{full_repo_name}${{issue}}");
     parser::replace_all_outside_ignore_blocks(&LINKED_RE, body, replace_by)
 }
 
@@ -115,6 +115,10 @@ fn edge_case_body() {
         fix_linked_issues("#132", full_repo_name),
         "rust-lang/rust#132"
     );
+    assert_eq!(
+        fix_linked_issues("(#132)", full_repo_name),
+        "(rust-lang/rust#132)"
+    );
 }
 
 #[test]