Skip to content

Commit de612a7

Browse files
committed
replace std::iter::once(_) with [_]
much more concise
1 parent e8cf373 commit de612a7

File tree

2 files changed

+8
-21
lines changed

2 files changed

+8
-21
lines changed

src/gh_range_diff.rs

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -579,11 +579,7 @@ impl UnifiedDiffPrinter for HtmlDiffPrinter<'_> {
579579
if let Some(&last) = before.last() {
580580
for &token in before {
581581
let token = self.0[token];
582-
self.handle_hunk_line(
583-
&mut f,
584-
HunkTokenStatus::Removed,
585-
std::iter::once((token, false)),
586-
)?;
582+
self.handle_hunk_line(&mut f, HunkTokenStatus::Removed, [(token, false)])?;
587583
}
588584
if !self.0[last].ends_with('\n') {
589585
writeln!(f)?;
@@ -593,11 +589,7 @@ impl UnifiedDiffPrinter for HtmlDiffPrinter<'_> {
593589
if let Some(&last) = after.last() {
594590
for &token in after {
595591
let token = self.0[token];
596-
self.handle_hunk_line(
597-
&mut f,
598-
HunkTokenStatus::Added,
599-
std::iter::once((token, false)),
600-
)?;
592+
self.handle_hunk_line(&mut f, HunkTokenStatus::Added, [(token, false)])?;
601593
}
602594
if !self.0[last].ends_with('\n') {
603595
writeln!(f)?;

src/github.rs

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1503,16 +1503,11 @@ impl Repository {
15031503
let filters = filters
15041504
.iter()
15051505
.map(|(key, val)| format!("{key}={val}"))
1506-
.chain(std::iter::once(format!(
1507-
"labels={}",
1508-
include_labels.join(",")
1509-
)))
1510-
.chain(std::iter::once("filter=all".to_owned()))
1511-
.chain(std::iter::once(format!("sort={}", ordering.sort,)))
1512-
.chain(std::iter::once(
1513-
format!("direction={}", ordering.direction,),
1514-
))
1515-
.chain(std::iter::once(format!("per_page={}", ordering.per_page,)))
1506+
.chain([format!("labels={}", include_labels.join(","))])
1507+
.chain(["filter=all".to_owned()])
1508+
.chain([format!("sort={}", ordering.sort)])
1509+
.chain([format!("direction={}", ordering.direction)])
1510+
.chain([format!("per_page={}", ordering.per_page)])
15161511
.collect::<Vec<_>>()
15171512
.join("&");
15181513
format!(
@@ -1535,7 +1530,7 @@ impl Repository {
15351530
.map(|(key, val)| format!("{key}:{val}"))
15361531
.chain(include_labels.iter().map(|label| format!("label:{label}")))
15371532
.chain(exclude_labels.iter().map(|label| format!("-label:{label}")))
1538-
.chain(std::iter::once(format!("repo:{}", self.full_name)))
1533+
.chain([format!("repo:{}", self.full_name)])
15391534
.collect::<Vec<_>>()
15401535
.join("+");
15411536
format!(

0 commit comments

Comments
 (0)