Fix tests and binaries

Author: Kobzol

src/bin/project_goals.rs

@@ -1,4 +1,5 @@
 use structopt::StructOpt;
+use triagebot::zulip::client::ZulipClient;
 use triagebot::{github::GithubClient, handlers::project_goals};
 
 /// A basic example
@@ -22,8 +23,10 @@ async fn main() -> anyhow::Result<()> {
 
     let opt = Opt::from_args();
     let gh = GithubClient::new_from_env();
+    let zulip = ZulipClient::new_from_env();
     project_goals::ping_project_goals_owners(
         &gh,
+        &zulip,
         opt.dry_run,
         opt.days_threshold,
         &opt.next_meeting_date,

src/tests/mod.rs

@@ -3,6 +3,7 @@ use crate::db::users::record_username;
 use crate::db::{make_client, ClientPool, PooledClient};
 use crate::github::GithubClient;
 use crate::handlers::Context;
+use crate::zulip::client::ZulipClient;
 use octocrab::Octocrab;
 use std::future::Future;
 use std::sync::Arc;
@@ -67,8 +68,13 @@ impl TestContext {
             "https://api.github.com/graphql".to_string(),
             "https://raw.githubusercontent.com".to_string(),
         );
+        let zulip = ZulipClient::new(
+            "https://rust-fake.zulipchat.com".to_string(),
+            "[email protected]".to_string(),
+        );
         let ctx = Context {
             github,
+            zulip,
             db: pool,
             username: "triagebot-test".to_string(),
             octocrab,

src/zulip.rs

@@ -15,10 +15,8 @@ use crate::zulip::api::{MessageApiResponse, Recipient};
 use crate::zulip::client::ZulipClient;
 use anyhow::{format_err, Context as _};
 use rust_team_data::v1::TeamKind;
-use std::env;
 use std::fmt::Write as _;
 use std::str::FromStr;
-use std::sync::LazyLock;
 use subtle::ConstantTimeEq;
 use tracing as log;
 

src/zulip/client.rs

@@ -25,7 +25,7 @@ impl ZulipClient {
         Self::new(instance_url, bot_email)
     }
 
-    fn new(instance_url: String, bot_email: String) -> Self {
+    pub fn new(instance_url: String, bot_email: String) -> Self {
         let client = Client::new();
         Self {
             client,