Do not comment if only rustbot is pinged in a commit message

Author: blyxyas

src/handlers/check_commits/no_mentions.rs

@@ -9,7 +9,10 @@ pub(super) fn mentions_in_commits(
 ) -> Option<String> {
     let mentions_commits = commits
         .into_iter()
-        .filter(|c| !parser::get_mentions(&c.commit.message).is_empty())
+        .filter(|c| {
+            let mentions = parser::get_mentions(&c.commit.message);
+            !mentions.is_empty() && mentions.iter().any(|m| *m != "rustbot")
+        })
         .map(|c| format!("- {}\n", c.sha))
         .collect::<String>();
 
@@ -44,6 +47,30 @@ Co-authored-by: Baz Qux <[email protected]>",
 
     assert_eq!(mentions_in_commits(&NoMentionsConfig {}, &commits), None);
 
+    commits.push(dummy_commit_from_body(
+        "6565ffdd8af4ca0ec7c8faceee59c582edcd83b2",
+        "This is a body that only mentions @rustbot for a command!",
+    ));
+
+    assert_eq!(mentions_in_commits(&NoMentionsConfig {}, &commits), None);
+
+    commits.push(dummy_commit_from_body(
+        "6565ffdd8af4ca0ec7c8faceee59c582edcd83b2",
+        "This is a body that mentions @rustbot for a command! And then a user @mention",
+    ));
+
+    assert_eq!(
+        mentions_in_commits(&NoMentionsConfig {}, &commits),
+        Some(
+            r"There are username mentions (such as `@user`) in the commit messages of the following commits.
+*Please remove the mentions to avoid spamming these users.*
+- 6565ffdd8af4ca0ec7c8faceee59c582edcd83b2
+".to_string()
+        )
+    );
+
+    let _ = commits.pop(); // Remove that @rustbot & @mention case
+    
     commits.push(dummy_commit_from_body(
         "d7daa17bc97df9377640b0d33cbd0bbeed703c3a",
         "This is a body with a @mention!",