Merge pull request #1960 from Urgau/warn-unreachable_pub

Apply `unreachable_pub` lint suggestions to our repository

Author: Kobzol

src/handlers/assign.rs

@@ -596,7 +596,7 @@ fn get_team_name<'a>(teams: &Teams, issue: &Issue, name: &'a str) -> Option<&'a
 }
 
 #[derive(PartialEq, Debug)]
-pub enum FindReviewerError {
+enum FindReviewerError {
     /// User specified something like `r? foo/bar` where that team name could
     /// not be found.
     TeamNotFound(String),

src/handlers/check_commits/behind_upstream.rs

@@ -2,10 +2,10 @@ use crate::github::{GithubClient, GithubCommit, IssuesEvent, Repository};
 use tracing as log;
 
 /// Default threshold for parent commit age in days to trigger a warning
-pub const DEFAULT_DAYS_THRESHOLD: usize = 7;
+pub(super) const DEFAULT_DAYS_THRESHOLD: usize = 7;
 
 /// Check if the PR is based on an old parent commit
-pub async fn behind_upstream(
+pub(super) async fn behind_upstream(
     age_threshold: usize,
     event: &IssuesEvent,
     client: &GithubClient,
@@ -64,7 +64,7 @@ pub async fn behind_upstream(
 ///     - If there is no parent commit
 ///     - If parent is within threshold
 /// - Err(...) - If an error occurred during processing
-pub async fn is_parent_commit_too_old(
+pub(super) async fn is_parent_commit_too_old(
     commit: &GithubCommit,
     repo: &Repository,
     client: &GithubClient,
@@ -85,7 +85,7 @@ pub async fn is_parent_commit_too_old(
 }
 
 /// Returns the number of days old the commit is
-pub async fn commit_days_old(
+pub(super) async fn commit_days_old(
     sha: &str,
     repo: &Repository,
     client: &GithubClient,

src/handlers/major_change.rs

@@ -9,7 +9,7 @@ use parser::command::second::SecondCommand;
 use tracing as log;
 
 #[derive(Clone, PartialEq, Eq, Debug)]
-pub enum Invocation {
+pub(super) enum Invocation {
     NewProposal,
     AcceptedProposal,
     Rename { prev_issue: ZulipGitHubReference },

src/handlers/milestone_prs.rs

@@ -7,7 +7,7 @@ use regex::Regex;
 use reqwest::StatusCode;
 use tracing as log;
 
-pub async fn handle(ctx: &Context, event: &Event) -> anyhow::Result<()> {
+pub(super) async fn handle(ctx: &Context, event: &Event) -> anyhow::Result<()> {
     let e = if let Event::Issue(e) = event {
         e
     } else {

src/handlers/note.rs

@@ -48,7 +48,7 @@ struct NoteDataEntry {
 }
 
 impl NoteDataEntry {
-    pub fn to_markdown(&self) -> String {
+    pub(crate) fn to_markdown(&self) -> String {
         format!(
             "\n- [\"{title}\" by @{author}]({comment_url})",
             title = self.title,
@@ -74,7 +74,7 @@ struct NoteData {
 }
 
 impl NoteData {
-    pub fn get_url_from_title(&self, title: &str) -> Option<String> {
+    pub(crate) fn get_url_from_title(&self, title: &str) -> Option<String> {
         let tmp = self.entries_by_url.clone();
         tmp.iter().sorted().find_map(|(key, val)| {
             if val.title == title {
@@ -85,7 +85,7 @@ impl NoteData {
         })
     }
 
-    pub fn remove_by_title(&mut self, title: &str) -> Option<NoteDataEntry> {
+    pub(crate) fn remove_by_title(&mut self, title: &str) -> Option<NoteDataEntry> {
         if let Some(url_to_remove) = self.get_url_from_title(title) {
             if let Some(entry) = self.entries_by_url.remove(&url_to_remove) {
                 log::debug!("SUCCESSFULLY REMOVED ENTRY: {:#?}", &entry);
@@ -100,7 +100,7 @@ impl NoteData {
         }
     }
 
-    pub fn to_markdown(&self) -> String {
+    pub(crate) fn to_markdown(&self) -> String {
         if self.entries_by_url.is_empty() {
             return String::new();
         }

src/handlers/notification.rs

@@ -14,7 +14,7 @@ use anyhow::Context as _;
 use std::collections::HashSet;
 use tracing as log;
 
-pub async fn handle(ctx: &Context, event: &Event) -> anyhow::Result<()> {
+pub(super) async fn handle(ctx: &Context, event: &Event) -> anyhow::Result<()> {
     let body = match event.comment_body() {
         Some(v) => v,
         // Skip events that don't have comment bodies associated

src/handlers/relnotes.rs

@@ -29,7 +29,7 @@ struct RelnotesState {
 
 const TITLE_PREFIX: &str = "Tracking issue for release notes";
 
-pub async fn handle(ctx: &Context, event: &Event) -> anyhow::Result<()> {
+pub(super) async fn handle(ctx: &Context, event: &Event) -> anyhow::Result<()> {
     let Event::Issue(e) = event else {
         return Ok(());
     };

src/handlers/rendered_link.rs

@@ -8,7 +8,7 @@ use crate::{
     handlers::Context,
 };
 
-pub async fn handle(
+pub(super) async fn handle(
     ctx: &Context,
     event: &Event,
     config: &RenderedLinkConfig,

src/tests/mod.rs

@@ -10,12 +10,12 @@ use tokio::sync::RwLock;
 use tokio_postgres::config::Host;
 use tokio_postgres::{Config, GenericClient};
 
-pub mod github;
+pub(crate) mod github;
 
 /// Represents a connection to a Postgres database that can be
 /// used in integration tests to test logic that interacts with
 /// a database.
-pub struct TestContext {
+pub(crate) struct TestContext {
     pool: ClientPool,
     ctx: Context,
     db_name: String,
@@ -83,15 +83,16 @@ impl TestContext {
     /// Returns a fake handler context.
     /// We currently do not mock outgoing nor incoming GitHub API calls,
     /// so the API endpoints will not be actually working.
-    pub fn handler_ctx(&self) -> &Context {
+    pub(crate) fn handler_ctx(&self) -> &Context {
         &self.ctx
     }
 
-    pub async fn db_client(&self) -> PooledClient {
+    pub(crate) async fn db_client(&self) -> PooledClient {
         self.pool.get().await
     }
 
-    pub async fn add_user(&self, name: &str, id: u64) {
+    #[allow(dead_code)]
+    pub(crate) async fn add_user(&self, name: &str, id: u64) {
         record_username(self.db_client().await.client(), id, name)
             .await
             .expect("Cannot create user");
@@ -113,7 +114,7 @@ impl TestContext {
     }
 }
 
-pub async fn run_test<F, Fut>(f: F)
+pub(crate) async fn run_test<F, Fut>(f: F)
 where
     F: FnOnce(TestContext) -> Fut,
     Fut: Future<Output = anyhow::Result<TestContext>>,