Feature request: Path AND content mentions

[fmease]

I know the existing TOML schema doesn't really lend itself to that but it would be quite handy if you could declare a [mentions] that requires the path to match a specific path (prefix) AND the patch to contain the addition of a specific pattern.

Regarding a concrete use case, see rust-lang/rust#146668 (comment) for context. I basically want the path to start with /library/ AND the pattern to be negative_bounds. Explainer: Adding #![feature(…, negative_bounds, …)] to the stdlib and friends is a hard no-go but it's okay to be used inside tests/.

Well, I guess I also want to denylist compiler/ tho that's not a hard requirement. So maybe I want an exclude_filepaths?: null | string[] instead (for allowlisting tests/ in my case)?

---

Hmm, feel free to close as WONTFIX if you deem this too complex / laborious.

[fmease]

(In the meantime I'll go ahead an add a pure content mention for negative_bounds.)

[cuviper]

For a "hard no-go", maybe it would be better as a tidy check?

[fmease]

Good shout, might be worth doing instead in my situation.

For context, earlier I was about to open a r-l/r PR with:

[mentions.negative_bounds]
type = "content"
message = """..."""
mentions = ["@fmease"] # need to ping *someone*, otherwise there's a risk of ppl ignoring the message in the sea of botspam

but I wasn't too happy about that.

[Urgau]

Agree, for "hard no-go" it would be better to have ./x tidy (and consequently CI fail), triagebot can't make CI fail.

If the need for path AND content mentions arises again we can re-evaluate the need for it.