Remove caching machinery

It didn't hit filesystem anyway so there's no I/O access penalty to be
amortized; in most common cases we'll have not more that 5ish top-level
workspace folders so the amount of work should be fairly minimal.

Author: Xanewok

src/extension.ts

@@ -112,7 +112,7 @@ function whenChangingWorkspaceFolders(e: WorkspaceFoldersChangeEvent) {
   // If a VSCode workspace has been added, check to see if it is part of an existing one, and
   // if not, and it is a Rust project (i.e., has a Cargo.toml), then create a new client.
   for (let folder of e.added) {
-    folder = getOuterMostWorkspaceFolder(folder, { cached: false });
+    folder = getOuterMostWorkspaceFolder(folder);
     if (workspaces.has(folder.uri.toString())) {
       continue;
     }

src/utils/workspace.ts

@@ -45,27 +45,16 @@ export function nearestParentWorkspace(
   return curWorkspace;
 }
 
-// This is an intermediate, lazy cache used by `getOuterMostWorkspaceFolder`
-// and should be regenerated when VSCode workspaces change.
-let _cachedSortedWorkspaceFolders: string[] | undefined;
-
 export function getOuterMostWorkspaceFolder(
   folder: WorkspaceFolder,
-  options?: { cached: boolean },
 ): WorkspaceFolder {
-  const recalculate = !options || !options.cached;
-  // Sort workspace folders or used already cached result, if possible
-  const sortedFolders =
-    !recalculate && _cachedSortedWorkspaceFolders
-      ? _cachedSortedWorkspaceFolders
-      : (workspace.workspaceFolders || [])
-          .map(folder => normalizeUriToPathPrefix(folder.uri))
-          .sort((a, b) => a.length - b.length);
-  _cachedSortedWorkspaceFolders = sortedFolders;
+  const sortedFoldersByPrefix = (workspace.workspaceFolders || [])
+    .map(folder => normalizeUriToPathPrefix(folder.uri))
+    .sort((a, b) => a.length - b.length);
 
   const uri = normalizeUriToPathPrefix(folder.uri);
 
-  const outermostPath = sortedFolders.find(prefix => uri.startsWith(prefix));
+  const outermostPath = sortedFoldersByPrefix.find(pre => uri.startsWith(pre));
   return outermostPath
     ? workspace.getWorkspaceFolder(Uri.parse(outermostPath)) || folder
     : folder;