Skip to content
This repository was archived by the owner on Nov 18, 2022. It is now read-only.

Commit 7b6be11

Browse files
committed
Revert "Dispose logger on extension deactivation"
This reverts commit 2c88563. That commit was wrong because we use-after-free the logger
1 parent 2c88563 commit 7b6be11

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

rust-analyzer/editors/code/src/main.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ async function tryActivate(context: vscode.ExtensionContext) {
4949
);
5050
context.subscriptions.push(defaultOnEnter);
5151

52-
context.subscriptions.push(log);
53-
5452
const config = new Config(context);
5553
const state = new PersistentState(context.globalState);
5654
const serverPath = await bootstrap(config, state).catch(err => {

rust-analyzer/editors/code/src/util.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ export const log = new class {
1818
private enabled = true;
1919
private readonly output = vscode.window.createOutputChannel("Rust Analyzer Client");
2020

21-
dispose() {
22-
log.output.dispose();
23-
}
24-
2521
setEnabled(yes: boolean): void {
2622
log.enabled = yes;
2723
}

0 commit comments

Comments
 (0)