Skip to content

Commit 2ade541

Browse files
committed
Unify logic for showing all Project Members and generating individual pages for each person
1 parent 871bada commit 2ade541

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

src/teams.rs

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ impl RustTeams {
209209
alumni.extend(team.alumni.iter().map(|m| (m.github_id, m)));
210210
}
211211
for team in &self.teams {
212-
if team.name != "alumni" {
212+
if is_active_team(&team) {
213213
alumni.extend(team.alumni.iter().map(|m| (m.github_id, m)));
214214
active.extend(team.members.iter().map(|m| (m.github_id, m)));
215215
}
@@ -278,15 +278,13 @@ impl RustTeams {
278278
}
279279
}
280280
for team in &self.teams {
281-
if team.kind == TeamKind::MarkerTeam && team.website_data.is_none() {
282-
continue;
283-
}
284-
285-
for member in &team.members {
286-
add_team(&mut people, self, member, team, TeamMode::Member);
287-
}
288-
for member in &team.alumni {
289-
add_team(&mut people, self, member, team, TeamMode::Alumni);
281+
if is_active_team(team) {
282+
for member in &team.members {
283+
add_team(&mut people, self, member, team, TeamMode::Member);
284+
}
285+
for member in &team.alumni {
286+
add_team(&mut people, self, member, team, TeamMode::Alumni);
287+
}
290288
}
291289
}
292290

@@ -322,6 +320,12 @@ impl RustTeams {
322320
}
323321
}
324322

323+
/// Is this a team for which we should display its members on the "All Project Members" page,
324+
/// and whose members should receive a separate person page?
325+
fn is_active_team(team: &Team) -> bool {
326+
team.name != "alumni"
327+
}
328+
325329
/// Get a relative URL of a team that should be appended to
326330
/// Should only be used for top-level teams.
327331
fn get_team_relative_url(team: &Team) -> String {

0 commit comments

Comments
 (0)