Merge pull request #1893 from senekor/clippy-config

Fix clippy config

Author: Manishearth

.github/workflows/main.yml

@@ -20,6 +20,7 @@ jobs:
           IFS=$'\n\t'
           # Check if the code is good
           cargo build --all --locked
+          cargo clippy -- --deny warnings
           cargo test --all --locked
 
       - name: Build the Docker image

src/main.rs

@@ -1,5 +1,3 @@
-#![cfg_attr(test, deny(warnings))]
-
 #[macro_use]
 extern crate lazy_static;
 extern crate rand;
@@ -284,6 +282,7 @@ fn redirect_bare_en_us() -> Redirect {
 }
 
 #[catch(404)]
+#[allow(clippy::result_large_err)]
 fn not_found(req: &Request) -> Result<Template, Redirect> {
     if let Some(redirect) = crate::redirect::maybe_redirect(req.uri().path()) {
         return Err(redirect);

src/teams.rs

@@ -155,7 +155,7 @@ impl Data {
         let mut subteams = Vec::with_capacity(raw_subteams.len());
         lay_out_subteams_hierarchically(&mut subteams, None, &main_team.name, &raw_subteams);
 
-        fn lay_out_subteams_hierarchically<'a>(
+        fn lay_out_subteams_hierarchically(
             result: &mut Vec<Team>,
             team: Option<&Team>,
             main_team: &str,