Skip to content

Commit bde1cb3

Browse files
authored
Merge pull request #191 from jb55/agdk-submodule
Update to GameActivity 4.0.0
2 parents ac2e17e + 69f3642 commit bde1cb3

File tree

43 files changed

+9715
-15027
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+9715
-15027
lines changed

android-activity/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
66

77
## [Unreleased]
88

9+
### Changed
910
- input: Replaced custom types with their `ndk` crate equivalent.
1011
> [!NOTE]
1112
> These types existed because the `ndk` crate didn't provide them in an extensible way. Now that they have the `#[non_exhaustive]` flag and contain a `__Unknown(T)` variant to provide lossless conversions, and not to mention use an ABI type that matches how it is being used by most functions (when the original constants were defined in a "typeless" way), the `ndk` types are used and reexported once again.
@@ -18,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1819
1920
- rust-version bumped to 1.73.0 ([#193](https://github.com/rust-mobile/android-activity/pull/193))
2021
- The `ndk` and `ndk-sys` crates are now re-exported under `android_activity::ndk` and `android_activity::ndk_sys` ([#194](https://github.com/rust-mobile/android-activity/pull/194))
22+
- GameActivity updated to 4.0.0 (requires the corresponding 4.0.0 `.aar` release from Google) ([#191](https://github.com/rust-mobile/android-activity/pull/191))
2123

2224
## [0.6.0] - 2024-04-26
2325

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
# android-games-sdk
2+
3+
This is an imported copy of the native "prefab" source for `GameActivity` and
4+
`GameTextInput`, from our fork of Google's
5+
[android-games-sdk](https://github.com/rust-mobile/android-games-sdk).
6+
7+
We use an external fork to track our integration patches on top of the Android
8+
Game Development Kit (AGDK) in a way that it is easier to update to new upstream
9+
versions. It also makes it easier to try and upstream changes when we fix bugs.
10+
11+
## Updating to new agdk version checklist
12+
13+
This is a basic checklist for things that need to be done when updating to a new
14+
agdk version:
15+
16+
- [ ] Create a new integration branch based on our last integrated branch and
17+
rebase that on the latest *release* branch from Google:
18+
19+
```bash
20+
git clone [email protected]:rust-mobile/android-games-sdk.git
21+
cd android-games-sdk
22+
git remote add google https://android.googlesource.com/platform/frameworks/opt/gamesdk
23+
git fetch google
24+
git checkout -b android-activity-5.0.0 origin/android-activity-4.0.0
25+
git rebase --onto google/android-games-sdk-game-activity-release <base>
26+
# (where <base> is the upstream commit ID below our stack of integration patches)
27+
```
28+
29+
- [ ] Set the `ANDROID_GAMES_SDK` environment variable so you can build
30+
android-activity against your external games-sdk branch while updating.
31+
- [ ] Re-generate the `GameActivity` FFI bindings with `./generate-bindings.sh`
32+
(this can be done with `ANDROID_GAMES_SDK` set in your environment and also
33+
repeated after importing)
34+
- [ ] Update [build.rs](../build.rs) with any new includes and src files
35+
- [ ] Update the `src/game-activity` backend as needed
36+
- [ ] Push a new `android-games-sdk` branch like `android-activity-5.0.0` that
37+
can be referenced when importing a copy into `android-activity`
38+
- [ ] Review and run `./import-games-sdk.sh` when ready to copy external AGDK
39+
code into this repo
40+
- [ ] Clearly reference the branch name and commit hash from the
41+
`android-games-sdk` repo in the `android-activity` commit that imports new
42+
games-sdk source.
43+
- [ ] Update CHANGELOG.md as required
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../../../../../include/common/

0 commit comments

Comments
 (0)