Upgrade jni to 0.21

Author: MarijnS95

Cargo.toml

@@ -7,5 +7,5 @@ license = "MIT"
 description = "Android intent utilities"
 
 [dependencies]
-jni = "0.20.0"
+jni = "0.21"
 ndk-context = "0.1.1"

example/Cargo.toml

@@ -9,7 +9,7 @@ crate_type=["lib", "cdylib"]
 [dependencies]
 android-activity = { version = "0.4.0", features = ["native-activity"] }
 android-intent = { path = "../" }
-jni = { version = "0.20.0" }
+jni = "0.21"
 ndk-context = "0.1.1"
 
 [package.metadata.android.sdk]

src/intent.rs

@@ -1,6 +1,6 @@
 use jni::{
     errors::Error,
-    objects::{JObject, JString},
+    objects::{JObject, JString, JValue},
     JNIEnv,
 };
 
@@ -27,14 +27,17 @@ impl<'env> Intent<'env> {
         Self { inner }
     }
 
-    pub fn new(env: JNIEnv<'env>, action: impl AsRef<str>) -> Self {
+    pub fn new(mut env: JNIEnv<'env>, action: impl AsRef<str>) -> Self {
         Self::from_fn(|| {
             let intent_class = env.find_class("android/content/Intent")?;
             let action_view =
-                env.get_static_field(intent_class, action.as_ref(), "Ljava/lang/String;")?;
+                env.get_static_field(&intent_class, action.as_ref(), "Ljava/lang/String;")?;
 
-            let intent =
-                env.new_object(intent_class, "(Ljava/lang/String;)V", &[action_view.into()])?;
+            let intent = env.new_object(
+                &intent_class,
+                "(Ljava/lang/String;)V",
+                &[action_view.borrow()],
+            )?;
 
             Ok(Inner {
                 env,
@@ -43,25 +46,30 @@ impl<'env> Intent<'env> {
         })
     }
 
-    pub fn new_with_uri(env: JNIEnv<'env>, action: impl AsRef<str>, uri: impl AsRef<str>) -> Self {
+    pub fn new_with_uri(
+        mut env: JNIEnv<'env>,
+        action: impl AsRef<str>,
+        uri: impl AsRef<str>,
+    ) -> Self {
         Self::from_fn(|| {
             let url_string = env.new_string(uri)?;
             let uri_class = env.find_class("android/net/Uri")?;
             let uri = env.call_static_method(
                 uri_class,
                 "parse",
                 "(Ljava/lang/String;)Landroid/net/Uri;",
-                &[JString::from(url_string).into()],
+                &[JValue::Object(&url_string)],
             )?;
 
             let intent_class = env.find_class("android/content/Intent")?;
-            let action_view =
-                env.get_static_field(intent_class, action.as_ref(), "Ljava/lang/String;")?;
+            let action_view = env
+                .get_static_field(&intent_class, action.as_ref(), "Ljava/lang/String;")?
+                .l()?;
 
             let intent = env.new_object(
-                intent_class,
+                &intent_class,
                 "(Ljava/lang/String;Landroid/net/Uri;)V",
-                &[action_view.into(), uri.into()],
+                &[JValue::Object(&action_view), uri.borrow()],
             )?;
 
             Ok(Inner {
@@ -80,16 +88,20 @@ impl<'env> Intent<'env> {
     /// intent.set_class_name("com.excample", "IntentTarget")
     /// # })
     /// ```
-    pub fn set_class_name(self, package_name: impl AsRef<str>, class_name: impl AsRef<str>) -> Self {
-        self.and_then(|inner| {
+    pub fn set_class_name(
+        self,
+        package_name: impl AsRef<str>,
+        class_name: impl AsRef<str>,
+    ) -> Self {
+        self.and_then(|mut inner| {
             let package_name = inner.env.new_string(package_name)?;
             let class_name = inner.env.new_string(class_name)?;
 
             inner.env.call_method(
-                inner.object,
+                &inner.object,
                 "setClassName",
                 "(Ljava/lang/String;Ljava/lang/String;)Landroid/content/Intent;",
-                &[package_name.into(), class_name.into()],
+                &[JValue::Object(&package_name), JValue::Object(&class_name)],
             )?;
 
             Ok(inner)
@@ -106,15 +118,15 @@ impl<'env> Intent<'env> {
     /// # })
     /// ```
     pub fn with_extra(self, key: impl AsRef<str>, value: impl AsRef<str>) -> Self {
-        self.and_then(|inner| {
+        self.and_then(|mut inner| {
             let key = inner.env.new_string(key)?;
             let value = inner.env.new_string(value)?;
 
             inner.env.call_method(
-                inner.object,
+                &inner.object,
                 "putExtra",
                 "(Ljava/lang/String;Ljava/lang/String;)Landroid/content/Intent;",
-                &[key.into(), value.into()],
+                &[JValue::Object(&key), JValue::Object(&value)],
             )?;
 
             Ok(inner)
@@ -136,18 +148,17 @@ impl<'env> Intent<'env> {
     pub fn into_chooser_with_title(self, title: Option<impl AsRef<str>>) -> Self {
         self.and_then(|mut inner| {
             let title_value = if let Some(title) = title {
-                let s = inner.env.new_string(title)?;
-                s.into()
+                inner.env.new_string(title)?
             } else {
-                JObject::null().into()
+                JString::default()
             };
 
             let intent_class = inner.env.find_class("android/content/Intent")?;
             let intent = inner.env.call_static_method(
                 intent_class,
                 "createChooser",
                 "(Landroid/content/Intent;Ljava/lang/CharSequence;)Landroid/content/Intent;",
-                &[inner.object.into(), title_value],
+                &[JValue::Object(&inner.object), JValue::Object(&title_value)],
             )?;
 
             inner.object = intent.try_into()?;
@@ -165,14 +176,14 @@ impl<'env> Intent<'env> {
     /// # })
     /// ```
     pub fn with_type(self, type_name: impl AsRef<str>) -> Self {
-        self.and_then(|inner| {
+        self.and_then(|mut inner| {
             let jstring = inner.env.new_string(type_name)?;
 
             inner.env.call_method(
-                inner.object,
+                &inner.object,
                 "setType",
                 "(Ljava/lang/String;)Landroid/content/Intent;",
-                &[jstring.into()],
+                &[JValue::Object(&jstring)],
             )?;
 
             Ok(inner)
@@ -183,12 +194,12 @@ impl<'env> Intent<'env> {
         let cx = ndk_context::android_context();
         let activity = unsafe { JObject::from_raw(cx.context() as jni::sys::jobject) };
 
-        self.inner.and_then(|inner| {
+        self.inner.and_then(|mut inner| {
             inner.env.call_method(
                 activity,
                 "startActivity",
                 "(Landroid/content/Intent;)V",
-                &[inner.object.into()],
+                &[JValue::Object(&inner.object)],
             )?;
 
             Ok(())

src/lib.rs

@@ -9,10 +9,10 @@ pub use intent::Intent;
 use jni::{JNIEnv, JavaVM};
 
 /// Run 'f' with the current [`JNIEnv`] from [`ndk_context`].
-pub fn with_current_env(f: impl FnOnce(JNIEnv)) {
+pub fn with_current_env(f: impl FnOnce(&JNIEnv<'_>)) {
     let cx = ndk_context::android_context();
     let vm = unsafe { JavaVM::from_raw(cx.vm().cast()) }.unwrap();
     let env = vm.attach_current_thread().unwrap();
 
-    f(env.clone());
+    f(&env);
 }