Use into_owned()

Author: termoshtt

Cargo.toml

@@ -14,7 +14,7 @@ lapack = "0.11.1"
 num-traits = "0.1.36"
 
 [dependencies.ndarray]
-version = "0.7"
+version = "0.7.3"
 features = ["blas"]
 
 [dev-dependencies]

src/hermite.rs

@@ -74,22 +74,18 @@ impl<A: HMFloat> HermiteMatrix for Array<A, Ix2> {
 
 impl<A: HMFloat> HermiteMatrix for RcArray<A, Ix2> {
     fn eigh(self) -> Result<(Self::Vector, Self), LinalgError> {
-        // XXX unnecessray clone (should use into_owned())
-        let (e, v) = self.to_owned().eigh()?;
+        let (e, v) = self.into_owned().eigh()?;
         Ok((e.into_shared(), v.into_shared()))
     }
     fn ssqrt(self) -> Result<Self, LinalgError> {
-        // XXX unnecessray clone (should use into_owned())
-        let s = self.to_owned().ssqrt()?;
+        let s = self.into_owned().ssqrt()?;
         Ok(s.into_shared())
     }
     fn cholesky(self) -> Result<Self, LinalgError> {
-        // XXX unnecessray clone (should use into_owned())
-        let s = self.to_owned().cholesky()?;
+        let s = self.into_owned().cholesky()?;
         Ok(s.into_shared())
     }
     fn deth(self) -> Result<Self::Scalar, LinalgError> {
-        // XXX unnecessray clone (should use into_owned())
-        self.to_owned().deth()
+        self.into_owned().deth()
     }
 }

src/matrix.rs

@@ -205,18 +205,15 @@ impl<A: MFloat> Matrix for RcArray<A, Ix2> {
         self.to_owned().opnorm_f()
     }
     fn svd(self) -> Result<(Self, Self::Vector, Self), LinalgError> {
-        // XXX unnecessary clone (should use into_owned())
-        let (u, s, v) = self.to_owned().svd()?;
+        let (u, s, v) = self.into_owned().svd()?;
         Ok((u.into_shared(), s.into_shared(), v.into_shared()))
     }
     fn qr(self) -> Result<(Self, Self), LinalgError> {
-        // XXX unnecessary clone (should use into_owned())
-        let (q, r) = self.to_owned().qr()?;
+        let (q, r) = self.into_owned().qr()?;
         Ok((q.into_shared(), r.into_shared()))
     }
     fn lu(self) -> Result<(Self::Permutator, Self, Self), LinalgError> {
-        // XXX unnecessary clone (should use into_owned())
-        let (p, l, u) = self.to_owned().lu()?;
+        let (p, l, u) = self.into_owned().lu()?;
         Ok((p, l.into_shared(), u.into_shared()))
     }
     fn permutate(&mut self, ipiv: &Self::Permutator) {