Skip to content

Commit c357c3d

Browse files
committed
Replace assert_allclose_l2 by all_close_l2(...).unwrap()
1 parent 6ecf638 commit c357c3d

File tree

8 files changed

+52
-50
lines changed

8 files changed

+52
-50
lines changed

tests/cholesky.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ fn cholesky() {
99
let c = a.clone().cholesky().unwrap();
1010
println!("c = \n{:?}", c);
1111
println!("cc = \n{:?}", c.t().dot(&c));
12-
c.t().dot(&c).assert_allclose_l2(&a, 1e-7);
12+
all_close_l2(&c.t().dot(&c), &a, 1e-7).unwrap();
1313
}
1414

1515
#[test]
@@ -21,5 +21,5 @@ fn cholesky_t() {
2121
let c = a.clone().cholesky().unwrap();
2222
println!("c = \n{:?}", c);
2323
println!("cc = \n{:?}", c.t().dot(&c));
24-
c.t().dot(&c).assert_allclose_l2(&a, 1e-7);
24+
all_close_l2(&c.t().dot(&c), &a, 1e-7).unwrap();
2525
}

tests/header.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ use ndarray::prelude::*;
1010
#[allow(unused_imports)]
1111
use ndarray_linalg::prelude::*;
1212
#[allow(unused_imports)]
13+
use ndarray_linalg::util::*;
14+
#[allow(unused_imports)]
1315
use ndarray_numtest::prelude::*;
1416
#[allow(unused_imports)]
1517
use ndarray_rand::RandomExt;

tests/inv.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ fn inv_random() {
66
let a = Array::<f64, _>::random((3, 3), r_dist);
77
let ai = a.clone().inv().unwrap();
88
let id = Array::eye(3);
9-
ai.dot(&a).assert_allclose_l2(&id, 1e-7);
9+
all_close_l2(&ai.dot(&a), &id, 1e-7).unwrap();
1010
}
1111

1212
#[test]
@@ -15,7 +15,7 @@ fn inv_random_t() {
1515
let a = Array::<f64, _>::random((3, 3), r_dist).reversed_axes();
1616
let ai = a.clone().inv().unwrap();
1717
let id = Array::eye(3);
18-
ai.dot(&a).assert_allclose_l2(&id, 1e-7);
18+
all_close_l2(&ai.dot(&a), &id, 1e-7).unwrap();
1919
}
2020

2121
#[test]

tests/lu.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ fn $testname() {
99
let p = $permutate; // replace 1-2
1010
let pa = a.permutated(&p);
1111
println!("permutated = \n{:?}", &pa);
12-
pa.assert_allclose_l2(&arr2($answer), 1e-7);
12+
all_close_l2(&pa, &arr2($answer), 1e-7).unwrap();
1313
}
1414
}} // end test_permutate
1515

@@ -22,7 +22,7 @@ fn $testname() {
2222
let p = $permutate; // replace 1-2
2323
let pa = a.permutated(&p);
2424
println!("permutated = \n{:?}", &pa);
25-
pa.assert_allclose_l2(&arr2($answer), 1e-7);
25+
all_close_l2(&pa, &arr2($answer), 1e-7).unwrap();
2626
}
2727
}} // end test_permutate_t
2828

@@ -58,7 +58,7 @@ fn test_lu(a: Array<f64, Ix2>) {
5858
println!("L = \n{:?}", &l);
5959
println!("U = \n{:?}", &u);
6060
println!("LU = \n{:?}", l.dot(&u));
61-
l.dot(&u).permutated(&p).assert_allclose_l2(&a, 1e-7);
61+
all_close_l2(&l.dot(&u).permutated(&p), &a, 1e-7).unwrap();
6262
}
6363

6464
macro_rules! test_lu_upper {

tests/qr.rs

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ fn qr_square_upper() {
1313
let (q, r) = a.clone().qr().unwrap();
1414
println!("q = \n{:?}", &q);
1515
println!("r = \n{:?}", &r);
16-
q.clone().assert_allclose_l2(&Array::eye(3), 1e-7);
17-
q.dot(&q.t()).assert_allclose_l2(&Array::eye(3), 1e-7);
18-
r.assert_allclose_l2(&a, 1e-7);
16+
all_close_l2(&q.clone(), &Array::eye(3), 1e-7).unwrap();
17+
all_close_l2(&q.dot(&q.t()), &Array::eye(3), 1e-7).unwrap();
18+
all_close_l2(&r, &a, 1e-7).unwrap();
1919
}
2020

2121
#[test]
@@ -31,9 +31,9 @@ fn qr_square_upper_t() {
3131
let (q, r) = a.clone().qr().unwrap();
3232
println!("q = \n{:?}", &q);
3333
println!("r = \n{:?}", &r);
34-
q.clone().assert_allclose_l2(&Array::eye(3), 1e-7);
35-
q.dot(&q.t()).assert_allclose_l2(&Array::eye(3), 1e-7);
36-
r.assert_allclose_l2(&a, 1e-7);
34+
all_close_l2(&q.clone(), &Array::eye(3), 1e-7).unwrap();
35+
all_close_l2(&q.dot(&q.t()), &Array::eye(3), 1e-7).unwrap();
36+
all_close_l2(&r, &a, 1e-7).unwrap();
3737
}
3838

3939
#[test]
@@ -44,8 +44,8 @@ fn qr_square() {
4444
let (q, r) = a.clone().qr().unwrap();
4545
println!("q = \n{:?}", &q);
4646
println!("r = \n{:?}", &r);
47-
q.dot(&q.t()).assert_allclose_l2(&Array::eye(3), 1e-7);
48-
q.dot(&r).assert_allclose_l2(&a, 1e-7);
47+
all_close_l2(&q.dot(&q.t()), &Array::eye(3), 1e-7).unwrap();
48+
all_close_l2(&q.dot(&r), &a, 1e-7).unwrap();
4949
}
5050

5151
#[test]
@@ -56,8 +56,8 @@ fn qr_square_t() {
5656
let (q, r) = a.clone().qr().unwrap();
5757
println!("q = \n{:?}", &q);
5858
println!("r = \n{:?}", &r);
59-
q.dot(&q.t()).assert_allclose_l2(&Array::eye(3), 1e-7);
60-
q.dot(&r).assert_allclose_l2(&a, 1e-7);
59+
all_close_l2(&q.dot(&q.t()), &Array::eye(3), 1e-7).unwrap();
60+
all_close_l2(&q.dot(&r), &a, 1e-7).unwrap();
6161
}
6262

6363
#[test]
@@ -73,9 +73,9 @@ fn qr_3x4_upper() {
7373
let (q, r) = a.clone().qr().unwrap();
7474
println!("q = \n{:?}", &q);
7575
println!("r = \n{:?}", &r);
76-
q.clone().assert_allclose_l2(&Array::eye(3), 1e-7);
77-
q.dot(&q.t()).assert_allclose_l2(&Array::eye(3), 1e-7);
78-
q.dot(&r).assert_allclose_l2(&a, 1e-7);
76+
all_close_l2(&q.clone(), &Array::eye(3), 1e-7).unwrap();
77+
all_close_l2(&q.dot(&q.t()), &Array::eye(3), 1e-7).unwrap();
78+
all_close_l2(&q.dot(&r), &a, 1e-7).unwrap();
7979
}
8080

8181
#[test]
@@ -91,9 +91,9 @@ fn qr_3x4_upper_t() {
9191
let (q, r) = a.clone().qr().unwrap();
9292
println!("q = \n{:?}", &q);
9393
println!("r = \n{:?}", &r);
94-
q.clone().assert_allclose_l2(&Array::eye(3), 1e-7);
95-
q.dot(&q.t()).assert_allclose_l2(&Array::eye(3), 1e-7);
96-
q.dot(&r).assert_allclose_l2(&a, 1e-7);
94+
all_close_l2(&q.clone(), &Array::eye(3), 1e-7).unwrap();
95+
all_close_l2(&q.dot(&q.t()), &Array::eye(3), 1e-7).unwrap();
96+
all_close_l2(&q.dot(&r), &a, 1e-7).unwrap();
9797
}
9898

9999
#[test]
@@ -104,8 +104,8 @@ fn qr_3x4() {
104104
let (q, r) = a.clone().qr().unwrap();
105105
println!("q = \n{:?}", &q);
106106
println!("r = \n{:?}", &r);
107-
q.dot(&q.t()).assert_allclose_l2(&Array::eye(3), 1e-7);
108-
q.dot(&r).assert_allclose_l2(&a, 1e-7);
107+
all_close_l2(&q.dot(&q.t()), &Array::eye(3), 1e-7).unwrap();
108+
all_close_l2(&q.dot(&r), &a, 1e-7).unwrap();
109109
}
110110

111111
#[test]
@@ -116,8 +116,8 @@ fn qr_3x4_t() {
116116
let (q, r) = a.clone().qr().unwrap();
117117
println!("q = \n{:?}", &q);
118118
println!("r = \n{:?}", &r);
119-
q.dot(&q.t()).assert_allclose_l2(&Array::eye(3), 1e-7);
120-
q.dot(&r).assert_allclose_l2(&a, 1e-7);
119+
all_close_l2(&q.dot(&q.t()), &Array::eye(3), 1e-7).unwrap();
120+
all_close_l2(&q.dot(&r), &a, 1e-7).unwrap();
121121
}
122122

123123
#[test]
@@ -133,8 +133,8 @@ fn qr_4x3_upper() {
133133
let (q, r) = a.clone().qr().unwrap();
134134
println!("q = \n{:?}", &q);
135135
println!("r = \n{:?}", &r);
136-
q.t().dot(&q).assert_allclose_l2(&Array::eye(3), 1e-7);
137-
q.dot(&r).assert_allclose_l2(&a, 1e-7);
136+
all_close_l2(&q.t().dot(&q), &Array::eye(3), 1e-7).unwrap();
137+
all_close_l2(&q.dot(&r), &a, 1e-7).unwrap();
138138
}
139139

140140
#[test]
@@ -150,8 +150,8 @@ fn qr_4x3_upper_t() {
150150
let (q, r) = a.clone().qr().unwrap();
151151
println!("q = \n{:?}", &q);
152152
println!("r = \n{:?}", &r);
153-
q.t().dot(&q).assert_allclose_l2(&Array::eye(3), 1e-7);
154-
q.dot(&r).assert_allclose_l2(&a, 1e-7);
153+
all_close_l2(&q.t().dot(&q), &Array::eye(3), 1e-7).unwrap();
154+
all_close_l2(&q.dot(&r), &a, 1e-7).unwrap();
155155
}
156156

157157
#[test]
@@ -162,8 +162,8 @@ fn qr_4x3() {
162162
let (q, r) = a.clone().qr().unwrap();
163163
println!("q = \n{:?}", &q);
164164
println!("r = \n{:?}", &r);
165-
q.t().dot(&q).assert_allclose_l2(&Array::eye(3), 1e-7);
166-
q.dot(&r).assert_allclose_l2(&a, 1e-7);
165+
all_close_l2(&q.t().dot(&q), &Array::eye(3), 1e-7).unwrap();
166+
all_close_l2(&q.dot(&r), &a, 1e-7).unwrap();
167167
}
168168

169169
#[test]
@@ -174,6 +174,6 @@ fn qr_4x3_t() {
174174
let (q, r) = a.clone().qr().unwrap();
175175
println!("q = \n{:?}", &q);
176176
println!("r = \n{:?}", &r);
177-
q.t().dot(&q).assert_allclose_l2(&Array::eye(3), 1e-7);
178-
q.dot(&r).assert_allclose_l2(&a, 1e-7);
177+
all_close_l2(&q.t().dot(&q), &Array::eye(3), 1e-7).unwrap();
178+
all_close_l2(&q.dot(&r), &a, 1e-7).unwrap();
179179
}

tests/ssqrt.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ fn ssqrt_symmetric_random() {
66
let mut a = Array::<f64, _>::random((3, 3), r_dist);
77
a = a.dot(&a.t());
88
let ar = a.clone().ssqrt().unwrap();
9-
ar.clone().reversed_axes().assert_allclose_l2(&ar, 1e-7);
9+
all_close_l2(&ar.clone().reversed_axes(), &ar, 1e-7).unwrap();
1010
}
1111

1212
#[test]
@@ -15,7 +15,7 @@ fn ssqrt_symmetric_random_t() {
1515
let mut a = Array::<f64, _>::random((3, 3), r_dist);
1616
a = a.dot(&a.t()).reversed_axes();
1717
let ar = a.clone().ssqrt().unwrap();
18-
ar.clone().reversed_axes().assert_allclose_l2(&ar, 1e-7);
18+
all_close_l2(&ar.clone().reversed_axes(), &ar, 1e-7).unwrap();
1919
}
2020

2121
#[test]
@@ -24,7 +24,7 @@ fn ssqrt_sqrt_random() {
2424
let mut a = Array::<f64, _>::random((3, 3), r_dist);
2525
a = a.dot(&a.t());
2626
let ar = a.clone().ssqrt().unwrap();
27-
ar.clone().reversed_axes().assert_allclose_l2(&ar, 1e-7);
27+
all_close_l2(&ar.clone().reversed_axes(), &ar, 1e-7).unwrap();
2828
}
2929

3030
#[test]
@@ -33,5 +33,5 @@ fn ssqrt_sqrt_random_t() {
3333
let mut a = Array::<f64, _>::random((3, 3), r_dist);
3434
a = a.dot(&a.t()).reversed_axes();
3535
let ar = a.clone().ssqrt().unwrap();
36-
ar.clone().reversed_axes().assert_allclose_l2(&ar, 1e-7);
36+
all_close_l2(&ar.clone().reversed_axes(), &ar, 1e-7).unwrap();
3737
}

tests/svd.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ fn svd_square() {
1111
for i in 0..3 {
1212
sm[(i, i)] = s[i];
1313
}
14-
u.dot(&sm).dot(&vt).assert_allclose_l2(&a, 1e-7);
14+
all_close_l2(&u.dot(&sm).dot(&vt), &a, 1e-7).unwrap();
1515
}
1616
#[test]
1717
fn svd_square_t() {
@@ -22,7 +22,7 @@ fn svd_square_t() {
2222
for i in 0..3 {
2323
sm[(i, i)] = s[i];
2424
}
25-
u.dot(&sm).dot(&vt).assert_allclose_l2(&a, 1e-7);
25+
all_close_l2(&u.dot(&sm).dot(&vt), &a, 1e-7).unwrap();
2626
}
2727

2828
#[test]
@@ -34,7 +34,7 @@ fn svd_4x3() {
3434
for i in 0..3 {
3535
sm[(i, i)] = s[i];
3636
}
37-
u.dot(&sm).dot(&vt).assert_allclose_l2(&a, 1e-7);
37+
all_close_l2(&u.dot(&sm).dot(&vt), &a, 1e-7).unwrap();
3838
}
3939
#[test]
4040
fn svd_4x3_t() {
@@ -45,7 +45,7 @@ fn svd_4x3_t() {
4545
for i in 0..3 {
4646
sm[(i, i)] = s[i];
4747
}
48-
u.dot(&sm).dot(&vt).assert_allclose_l2(&a, 1e-7);
48+
all_close_l2(&u.dot(&sm).dot(&vt), &a, 1e-7).unwrap();
4949
}
5050

5151
#[test]
@@ -57,7 +57,7 @@ fn svd_3x4() {
5757
for i in 0..3 {
5858
sm[(i, i)] = s[i];
5959
}
60-
u.dot(&sm).dot(&vt).assert_allclose_l2(&a, 1e-7);
60+
all_close_l2(&u.dot(&sm).dot(&vt), &a, 1e-7).unwrap();
6161
}
6262
#[test]
6363
fn svd_3x4_t() {
@@ -68,7 +68,7 @@ fn svd_3x4_t() {
6868
for i in 0..3 {
6969
sm[(i, i)] = s[i];
7070
}
71-
u.dot(&sm).dot(&vt).assert_allclose_l2(&a, 1e-7);
71+
all_close_l2(&u.dot(&sm).dot(&vt), &a, 1e-7).unwrap();
7272
}
7373

7474
#[test]
@@ -83,5 +83,5 @@ fn svd_large() {
8383
for i in 0..min(n, m) {
8484
sm[(i, i)] = s[i];
8585
}
86-
u.dot(&sm).dot(&vt).assert_allclose_l2(&a, 1e-7);
86+
all_close_l2(&u.dot(&sm).dot(&vt), &a, 1e-7).unwrap();
8787
}

tests/triangular.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ fn solve_upper() {
1010
let x = a.solve_upper(b.clone()).unwrap();
1111
println!("x = \n{:?}", &x);
1212
println!("Ax = \n{:?}", a.dot(&x));
13-
a.dot(&x).assert_allclose_l2(&b, 1e-7);
13+
all_close_l2(&a.dot(&x), &b, 1e-7).unwrap();
1414
}
1515

1616
#[test]
@@ -23,7 +23,7 @@ fn solve_upper_t() {
2323
let x = a.solve_upper(b.clone()).unwrap();
2424
println!("x = \n{:?}", &x);
2525
println!("Ax = \n{:?}", a.dot(&x));
26-
a.dot(&x).assert_allclose_l2(&b, 1e-7);
26+
all_close_l2(&a.dot(&x), &b, 1e-7).unwrap();
2727
}
2828

2929
#[test]
@@ -36,7 +36,7 @@ fn solve_lower() {
3636
let x = a.solve_lower(b.clone()).unwrap();
3737
println!("x = \n{:?}", &x);
3838
println!("Ax = \n{:?}", a.dot(&x));
39-
a.dot(&x).assert_allclose_l2(&b, 1e-7);
39+
all_close_l2(&a.dot(&x), &b, 1e-7).unwrap();
4040
}
4141

4242
#[test]
@@ -49,5 +49,5 @@ fn solve_lower_t() {
4949
let x = a.solve_lower(b.clone()).unwrap();
5050
println!("x = \n{:?}", &x);
5151
println!("Ax = \n{:?}", a.dot(&x));
52-
a.dot(&x).assert_allclose_l2(&b, 1e-7);
52+
all_close_l2(&a.dot(&x), &b, 1e-7).unwrap();
5353
}

0 commit comments

Comments
 (0)