Drop unsafe of cholesky

Author: termoshtt

lax/src/cholesky.rs

@@ -8,32 +8,37 @@ pub trait Cholesky_: Sized {
     /// Cholesky: wrapper of `*potrf`
     ///
     /// **Warning: Only the portion of `a` corresponding to `UPLO` is written.**
-    unsafe fn cholesky(l: MatrixLayout, uplo: UPLO, a: &mut [Self]) -> Result<()>;
+    fn cholesky(l: MatrixLayout, uplo: UPLO, a: &mut [Self]) -> Result<()>;
+
     /// Wrapper of `*potri`
     ///
     /// **Warning: Only the portion of `a` corresponding to `UPLO` is written.**
-    unsafe fn inv_cholesky(l: MatrixLayout, uplo: UPLO, a: &mut [Self]) -> Result<()>;
+    fn inv_cholesky(l: MatrixLayout, uplo: UPLO, a: &mut [Self]) -> Result<()>;
+
     /// Wrapper of `*potrs`
-    unsafe fn solve_cholesky(l: MatrixLayout, uplo: UPLO, a: &[Self], b: &mut [Self])
-        -> Result<()>;
+    fn solve_cholesky(l: MatrixLayout, uplo: UPLO, a: &[Self], b: &mut [Self]) -> Result<()>;
 }
 
 macro_rules! impl_cholesky {
     ($scalar:ty, $trf:path, $tri:path, $trs:path) => {
         impl Cholesky_ for $scalar {
-            unsafe fn cholesky(l: MatrixLayout, uplo: UPLO, a: &mut [Self]) -> Result<()> {
+            fn cholesky(l: MatrixLayout, uplo: UPLO, a: &mut [Self]) -> Result<()> {
                 let (n, _) = l.size();
-                $trf(l.lapacke_layout(), uplo as u8, n, a, n).as_lapack_result()?;
+                unsafe {
+                    $trf(l.lapacke_layout(), uplo as u8, n, a, n).as_lapack_result()?;
+                }
                 Ok(())
             }
 
-            unsafe fn inv_cholesky(l: MatrixLayout, uplo: UPLO, a: &mut [Self]) -> Result<()> {
+            fn inv_cholesky(l: MatrixLayout, uplo: UPLO, a: &mut [Self]) -> Result<()> {
                 let (n, _) = l.size();
-                $tri(l.lapacke_layout(), uplo as u8, n, a, l.lda()).as_lapack_result()?;
+                unsafe {
+                    $tri(l.lapacke_layout(), uplo as u8, n, a, l.lda()).as_lapack_result()?;
+                }
                 Ok(())
             }
 
-            unsafe fn solve_cholesky(
+            fn solve_cholesky(
                 l: MatrixLayout,
                 uplo: UPLO,
                 a: &[Self],
@@ -42,8 +47,10 @@ macro_rules! impl_cholesky {
                 let (n, _) = l.size();
                 let nrhs = 1;
                 let ldb = 1;
-                $trs(l.lapacke_layout(), uplo as u8, n, nrhs, a, l.lda(), b, ldb)
-                    .as_lapack_result()?;
+                unsafe {
+                    $trs(l.lapacke_layout(), uplo as u8, n, nrhs, a, l.lda(), b, ldb)
+                        .as_lapack_result()?;
+                }
                 Ok(())
             }
         }

ndarray-linalg/src/cholesky.rs

@@ -155,7 +155,7 @@ where
 
     fn invc_into(self) -> Result<Self::Output> {
         let mut a = self.factor;
-        unsafe { A::inv_cholesky(a.square_layout()?, self.uplo, a.as_allocated_mut()?)? };
+        A::inv_cholesky(a.square_layout()?, self.uplo, a.as_allocated_mut()?)?;
         triangular_fill_hermitian(&mut a, self.uplo);
         Ok(a)
     }
@@ -173,14 +173,12 @@ where
     where
         Sb: DataMut<Elem = A>,
     {
-        unsafe {
-            A::solve_cholesky(
-                self.factor.square_layout()?,
-                self.uplo,
-                self.factor.as_allocated()?,
-                b.as_slice_mut().unwrap(),
-            )?
-        };
+        A::solve_cholesky(
+            self.factor.square_layout()?,
+            self.uplo,
+            self.factor.as_allocated()?,
+            b.as_slice_mut().unwrap(),
+        )?;
         Ok(b)
     }
 }
@@ -259,7 +257,7 @@ where
     S: DataMut<Elem = A>,
 {
     fn cholesky_inplace(&mut self, uplo: UPLO) -> Result<&mut Self> {
-        unsafe { A::cholesky(self.square_layout()?, uplo, self.as_allocated_mut()?)? };
+        A::cholesky(self.square_layout()?, uplo, self.as_allocated_mut()?)?;
         Ok(self.into_triangular(uplo))
     }
 }